Fix tutor7pp ausgab and output bugs #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainegra
previously approved these changes
Jun 8, 2018
blakewalters
previously approved these changes
Jun 8, 2018
rtownson
force-pushed
the
fix-ausgab-bug
branch
2 times, most recently
from
beae928
to
fcf66f7
Compare
rtownson
dismissed stale reviews from mainegra and blakewalters
new changes need review
rtownson
changed the title
rtownson
changed the title
mainegra
approved these changes
Jun 28, 2018
ftessier
force-pushed
the
fix-ausgab-bug
branch
from
4e89a0b
to
1fc7a30
Compare
ftessier
approved these changes
Sep 19, 2018
blakewalters
approved these changes
Sep 26, 2018
Fix a tutor7pp bug related to ausgab calls. The value of whether or not to do russian roulette was not initialized properly. When an ausgab object was included in the input file, results differed due to random memory accesses. The results were correct when no ausgab objects were included. This is therefore a critical bug fix for tutor7pp. Also add some ausgab call values that were missing in application.h, for future use and consistency.
Fix a bug in tutor7pp where the pulse-height distribution (PHD) regions specified in the input file were not associated with the correct regions. The PHDs that were output corresponded to ir+1, but the input and output suggested that they corresponded to ir. Now, the PHDs are output for the correct regions and there is additional description of the output format.
ftessier
force-pushed
the
fix-ausgab-bug
branch
from
1fc7a30
to
d487479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tutor7ppbug related to ausgab calls. When an ausgab object was used in the input file, results differed due to random memory accesses. This was due to an uninitialized value related to russian roulette, when it was not turned on. However, the results were correct when no ausgab objects were used.This is therefore a critical bug fix for
tutor7pp. Thanks to Nigel Vezeau for reporting this bug.tutor7ppbug where the pulse height regions specified by the user in the input file were not associated with the correct regions. The PHDs that were output corresponded toir+1, but the input/output suggested that they corresponded toir. Now, the PHDs are output for the correct regions and there is additional description of the output format.Thanks to Lucas Paixão for reporting this bug.
application.h. This change is just for future use and consistency.