Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #388, #383: concave CD, XYZ inside CD, conestack, and box geometry errors #462

Merged
merged 4 commits into from
Mar 7, 2019
Merged

Fix #388, #383: concave CD, XYZ inside CD, conestack, and box geometry errors #462

merged 4 commits into from
Mar 7, 2019

Commits on Mar 5, 2019

  1. Fix #388: concave cd geometry errors 

    Address a special case where convex geometries result in a concave cd
geometry when combined. This showed up as geometry errors and could be
created using a radius-mismatched cylinder and sphere in a cd geometry.
Also fix a bug where a small step is taken in the cylinder or sphere
howfar() routine by boundaryTolerance/2 instead of boundaryTolerance,
causing checks against the boundaryTolerance to fail in the cd geometry.
    @rtownson @ftessier
    rtownson authored and ftessier committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    8f81321 View commit details
    Browse the repository at this point in the history

  2. Fix #383: xyz geometry errors in cd and envelope 

    Resort to the boundaryTolerance parameter to avoid particles getting
stuck at edges when an xyz geometry serves as a cd base geometry, which
is subsequently inscribed in an envelope.
    @rtownson @ftessier
    rtownson authored and ftessier committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    1dc8296 View commit details
    Browse the repository at this point in the history

  3. Avoid infinite loop in conestack geometry 

    Resort to the boundaryTolerance parameter to avoid a rare but possible
infinite loop trap in simulations with a conestack geometry comprising
more than one layer, causing particles to get stuck on the surface
between layers in the conestack.
    @rtownson @ftessier
    rtownson authored and ftessier committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    9f94ea4 View commit details
    Browse the repository at this point in the history

  4. Curb errors at box corners with strict inequality 

    Change comparison operators from inequalities to strict inequalities, in
order to avoid particles getting stuck at corners in an egs_box
geometry.
    @rtownson @ftessier
    rtownson authored and ftessier committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    116dfd3 View commit details
    Browse the repository at this point in the history