Fix egs_view simulation geometry selection #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainegra
approved these changes
Sep 14, 2018
ftessier
approved these changes
Sep 19, 2018
Fix the egs_view simulation geometry selection so that only geometries that are actually named in the input file can be selected. When selecting the simulation geometry, the view window now resets the camera position to find a point within the new geometry. Fix a bug where the axis did not display correctly at certain view angles when the geometry was not near the origin. Fix a bug in egs_cylinders where the geometry type was not defined. This is necessary so that the type displays correctly in egs_view.
ftessier
force-pushed
the
feature-egs-view-updates
branch
from
fcd1ec8
to
9f812e1
Compare
blakewalters
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the egs_view simulation geometry selection so that only geometries that are actually named in the input file can be selected. When selecting the simulation geometry, the view window now resets the camera position to find a point within the new geometry.
Fix a bug where the axis did not display correctly at certain view angles when the geometry was not near the origin.
Fix a bug in egs_cylinders where the geometry type was not defined. This was only necessary so that the type was displayed correctly in egs_view.