Fix Win egs_system function #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakewalters
approved these changes
Jan 29, 2019
rtownson
approved these changes
Jan 29, 2019
ftessier
force-pushed
the
fix-win-egs_system
branch
from
9e751da
to
7623276
Compare
|
Just removed the formatting commits (will put that on the small-stuff branch for the whole |
ftessier
approved these changes
Jan 29, 2019
Toggle between MergedChannels and SeparateChannels testing modes in egs_configure. Parallel runs on Windows were failing to combine *.egsdat files at the end of the simulation, because the system command exit status check was failing, hence a dummy egs_system function always returned success. One can check for successful compilation only or also for successful execution by checking the test code output against a reference value. Depending what mode is needed the QProcess communication channels for standard output and error can be merged or separated. Modify the system test echo argument: use 'echo off' to test the system command on Windows, instead of 'echo hallo' which interfered with the test output, making the test fail when it actually succeeded.
ftessier
force-pushed
the
fix-win-egs_system
branch
from
7623276
to
f0cdc15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Parallel runs on Windows were failing to combine
*.egsdatfiles. Reported by Alex Bielajew.Cause: check for exit status from the
systemfunction and subroutine was failing on Windows.As a consequence, a dummy
egs_systemfuntion always returned a successful command execution status.One can now submit parallel jobs on Windows to all available cores on a given PC and get the combined results.