Fix bug introduced by PR #532 #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftessier
approved these changes
Nov 21, 2019
ftessier
force-pushed
the
fix-pr-532-bug
branch
from
122a741
to
75638b6
Compare
mainegra
approved these changes
Nov 21, 2019
Fix a bug that caused any egs++ application to crash immediately when run. This happened due to a misuse of string method find_last_of instead of method rfind to reverse-search for the ".exe" extension substring in the application name.
ftessier
force-pushed
the
fix-pr-532-bug
branch
from
75638b6
to
2c50bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that caused any of the characters in ".exe" found in an application name or input file to crash the run. This happened due to a mistaken use of
find_last_of()instead ofrfind()when searching for an extension on the application name.This bug only made it into the
developbranch for 1 day.