Add egs_circle_perpendicular shape #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainegra
approved these changes
Jul 20, 2020
blakewalters
approved these changes
Jan 18, 2021
Add a circle shape that, when used as a target shape in a source, acts as a circle that is always perpendicular to the incident source particle.
ftessier
force-pushed
the
add-circle-perpendicular
branch
from
58def29
to
19169d2
Compare
|
Rebased on develop. |
Fix the particle weights when egs_circle_perpendicular is used as a target. Previously the weighting was based on the viewing angle of the circle along the z axis, because the circle was always in the xy plane in egs_circle. Now, since the circle face changes direction the weighting is constant with viewing angle.
ftessier
force-pushed
the
add-circle-perpendicular
branch
from
19169d2
to
a6638cd
Compare
|
Removed EOL whitespace introduced in second commit. |
Fix special cases where u.z is parallel or antiparallel with the z axis, resulting incorrectly in a zero vector.
ftessier
force-pushed
the
add-circle-perpendicular
branch
from
a6638cd
to
6c89ad9
Compare
|
Ran astyle on header file. |
ftessier
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new circle shape where the angle of the surface of the circle depends on the position of the source particle directed toward it.
This shape is specified via
and delivers points uniformly distributed within a circle. The surface of this circle is always perpendicular to a ray based on the source particle position, when this shape is used as the target in a source that calls the
getPointSourceDirection()function. For example, in a collimated source when a source shape and target shape are defined, the special properties of this circle only apply when it is used as the target shape. Otherwise, it behaves like an egs_circle.For each source particle, when
getPointSourceDirection()is called, the circle shape is rotated so that the circle surface is perpendicular to the vector between the source location, and the origin of the circle. In effect this means that the source particles see a sphere instead of a circle, except that for a given particle, the possible target locations are on the surface of a circle rather than within a sphere.Thanks to Nathan Murtha for both requesting and helping to debug this feature!