Add check for maximum number of particles to addphsp #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtownson
changed the title
rtownson
approved these changes
Jun 28, 2022
mainegra
approved these changes
Jun 30, 2022
ftessier
force-pushed
the
elegant_addphsp_exit
branch
from
8f8d56c
to
10832ac
Compare
Implement a graceful exit from the addphsp application if the total number of particles is greater than 2^32-1, the maximum count that can be stored in the header. Only enforce this for a phase space in EGSnrc format.
ftessier
force-pushed
the
elegant_addphsp_exit
branch
from
10832ac
to
9710870
Compare
|
Squashed 2 commits and adjust commit message. |
ftessier
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For EGSnrc format phsp if total no. of particles in header > 2^32-1.
Addresses Issue #724.