Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directional radiative splitting (DRS) egs++ ausgab object #884

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

ftessier
Copy link
Member

Implement a radiative splitting ausgab object. These commits were extracted out of pull request #878. This is work in progress, not ready for merging.

@ftessier ftessier added the work in progress Work in progress, don't merge yet label Jun 30, 2022
@ftessier ftessier added this to the Release 2023 milestone Jun 30, 2022
@ftessier ftessier requested review from mainegra, rtownson, blakewalters and a team June 30, 2022 22:29
@ftessier ftessier changed the title Feature radiative splitting Add radiative splitting egs++ ausgab object Jun 30, 2022
Copy link
Collaborator

@rtownson rtownson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this compatible with egs_track_scoring?

int imed;

const char *dbs_err_msg =
"Stack size exceeded in BEAMpp_DBS::%s()\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should refer to egs_radiative_splitting not BEAMpp_DBS

@mainegra
Copy link
Contributor

mainegra commented Jul 4, 2022

I would call this pull request: Add directional radiative splitting (DRS) egs++ ausgab object
We already have UBS implemented as part of this AO. This particular PR incorporates the directional option, which is a WIP.

@ftessier ftessier changed the title Add radiative splitting egs++ ausgab object Add directional radiative splitting (DRS) egs++ ausgab object Jul 4, 2022
link to egs_advanced_appliction.o when
compiling shared lib.
Note: Currently does not work.  This commit
is just to save recent changes.
Overrides key macros from egs_c_interface2.macros.
required EGSnrc calls in egs_advanced_application.

Also correcting some of the functions erroneously
coded with np->np+1!
1. Add calls to EGSnrc subroutines to egs_advanced_application
2. Fix major bugs in DBS algorithm
3. Introduce initializeData ausgab_object function.
This must also be copied into the application directory.
1. Not deleting top particle before doSmartCompton and
   split Rayleigh interactions
2. Calculating nsample in doSmartCompton
3. etc.
These are now accessed throuh EGS_AdvancedApplication.

Also disabled DRSf (BEAMnrc-style DRS) option.
Forgot to subtract 2 from ir before saving to the_stack.
@ftessier ftessier force-pushed the feature-radiative-splitting branch from fac4264 to 5cdd650 Compare August 3, 2023 13:01
@rtownson rtownson modified the milestones: Release 2024, Release 2025 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Work in progress, don't merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants