-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use position/direction sampling from base source for radionuclide sources #896
Conversation
b75ca82
to
e2c3448
Compare
Rebased on develop. |
e2c3448
to
e715e5b
Compare
Something ain't right. The second (last) commit reverts apparently legitimate changes, for example adding the name of the contributor and updating the documentation. @MartinMartinov or @rtownson, any chance you can shed light on this? For the record, this pull request was reinstated from #672, from a branch obtained as follows:
|
Yes the missing contributor/documentation looks like a mistake, not sure how it happened. When you re-instate it, change the indentations to use spaces instead of tabs. |
Yes I will run astyle. So are you confirming that the other changes in that commit are all good then? I will attempt to clean it up and wait for review. |
Yes, the comments from the first commit are correct. The code added in the second commit is also correct. This PR breaks backwards compatibility - users with radionuclide sources will have to update their input files. I think that's OK, maintaining backwards compatibility would result in a lot of duplicate code. |
e715e5b
to
10892a1
Compare
@rtownson I think I got it sorted out with the last push. Can you take a look? Applied astyle. |
Yep, looks right! |
I'm going to add one more commit to add a check for the old deprecated inputs, and give a description of the new format. |
0ebe771
to
a3f7c5a
Compare
HEN_HOUSE/egs++/sources/egs_radionuclide_source/egs_radionuclide_source.h
Outdated
Show resolved
Hide resolved
HEN_HOUSE/egs++/sources/egs_radionuclide_source/egs_radionuclide_source.h
Show resolved
Hide resolved
Change the egs_radionuclude_source to take an input "base source" instead of defining a collimated or isotropic source. This way, any of the egs++ sources or a custom source can now be used to define the distribution of the radionuclide. Also, add warning messages for deprecated radionuclide source inputs. This change was originally motivated by simulations of targeted radionuclide therapy.
e655d6a
to
7627126
Compare
Rebased on develop, squashed and tweaked commit message. Also, remove the year from the contributor line in the header, to match EGSnrc style (only the author has the year indicated, to preserve pre-git history; now contribution date is provided by the git log) |
This pull request replaces #672. The original pull request branch was removed from the forked repository, so the branch and pull request is hereby reinstated. The original pull request message was: