Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add citation info to docs and update README badges #236

Merged
merged 5 commits into from
Jul 24, 2020

Conversation

richford
Copy link
Member

Resolves #231

[![Codacy Badge](https://api.codacy.com/project/badge/Coverage/d6fa3a18646f4a8089c7c897819d0342)](https://www.codacy.com/app/nrdg/cloudknot?utm_source=github.com&utm_medium=referral&utm_content=nrdg/cloudknot&utm_campaign=Badge_Coverage)
[![Build Status](https://github.com/nrdg/cloudknot/workflows/build/badge.svg)]
[![Codacy Badge](https://app.codacy.com/project/badge/Grade/d6fa3a18646f4a8089c7c897819d0342)](https://www.codacy.com/manual/richford/cloudknot?utm_source=github.com&utm_medium=referral&utm_content=nrdg/cloudknot&utm_campaign=Badge_Grade)
[![Codacy Badge](https://app.codacy.com/project/badge/Coverage/d6fa3a18646f4a8089c7c897819d0342)](https://www.codacy.com/manual/richford/cloudknot?utm_source=github.com&utm_medium=referral&utm_content=nrdg/cloudknot&utm_campaign=Badge_Coverage)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

Copy link
Member Author

@richford richford Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to change the coverage badge since codacy believes it hasn't received any coverage info yet. I recommend we open a new issue to fix coverage upload to codacy and don't let it hold up these PRs and the release of v0.4.1.

@arokem
Copy link
Member

arokem commented Jul 23, 2020

Question: once we wrap this one up are we ready to make a new release? Or is there any other pending issues that are blocking that?

@richford
Copy link
Member Author

This will close one of the remaining issues for v0.4.1. The only other one is to write a publication script for the maintainers and document it in CONTRIBUTING.md.

@arokem arokem added this to the v0.4.1 milestone Jul 24, 2020
@arokem arokem merged commit 6603114 into nrdg:master Jul 24, 2020
@richford richford deleted the badges branch July 24, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add citation instructions
2 participants