Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10s delay on Win10 #49

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Fix 10s delay on Win10 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b10586
Fix 10s delay on Win10
nref Nov 20, 2024
fb39c19
Bump version
nref Nov 20, 2024
339e893
Update signtool path
nref Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions BrowseRouter/NotifyService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ public async Task NotifyAsync(string title, string message)
if (isWindows11)
return;

await RemoveTrayIconLater(nid);
}

private async Task RemoveTrayIconLater(NotifyIconData nid)
{
// Windows 11 removes the tray icon when the app exits.
// On Windows 10, we have to remove it manually.
// But also on Windows 10, removing the icon immediately hides the pop-up message, so we have to delay.
Expand Down
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<LangVersion>latest</LangVersion>
<Version>0.12.4</Version>
<Version>0.12.5</Version>
<Product>BrowseRouter</Product>
<Copyright>EnduraByte LLC 2024</Copyright>
<!-- Reduces flagging as malware -->
Expand Down
2 changes: 1 addition & 1 deletion Publish-And-Sign.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ param (
)

$certKey = $env:ENDURABYTE_WINDOWS_CODE_SIGN_KEY
$signTool = "C:\Program Files (x86)\Windows Kits\10\App Certification Kit\signtool.exe"
$signTool = "signtool.exe"
$rids = @("win-x64", "win-arm64")

# dotnet does not support publishing multiple RIDs in parallel
Expand Down
Loading