[nrf noup][ZAP] Improve west zap generate command #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
force-pushed
the
fix_zap_and_zcl
branch
2 times, most recently
from
35f173e to
1bf5d0d
Compare
When arguments have a custom type (such as struct or enum), they must be added to the `attributeAccessInterfaceAttributes` list in the `zcl.json` file. If this is not done, the generated Accessors.h/.cpp files will not have access to these custom types. This commit introduces a new `add_custom_attributes` function to the west `zap-append`/`zap-gui` command to handle updating the zcl file with all custom-type attributes. The second improvement is the ability to synchronize the zcl file with the "base" zcl file located in the Matter SDK. This is useful if the base file has changed, for example due to a new Matter SDK version, and the custom zcl file does not contain all the "base" clusters. Both improvements are necessary only when calling west `zap-generate` with the `--full` argument. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
fix_zap_and_zcl
branch
from
1bf5d0d to
6ba7b16
Compare
kkasperczyk-no
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arguments have a custom type (such as struct or enum), they must be added to the
attributeAccessInterfaceAttributeslist in thezcl.jsonfile. If this is not done, the generated Accessors.h/.cpp files will not have access to these custom types.This commit introduces a new
add_custom_attributesfunction to the westzap-generatecommand to handle updating the zcl file with all custom-type attributes.The second improvement is the ability to synchronize the zcl file with the "base" zcl file located in the Matter SDK. This is useful if the base file has changed, for example, due to a new Matter SDK version, and the custom zcl file does not contain all the "base" clusters.
Both improvements are necessary only when calling west
zap-generatewith the--fullargument.Testing
NRF