Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf noup] ci: use Standard Library in Jenkinsfile to link sub-projects together #45

Merged
merged 2 commits into from
Jul 22, 2019

Conversation

thst-nordic
Copy link

@thst-nordic thst-nordic commented Jul 11, 2019

Managing Docker version, Agent Labels, Github Status, manifest updates, downstream jobs from CI_LIB.

More info: https://projecttools.nordicsemi.no/confluence/display/NCS/Linking+Jenkins+Jobs+Together

Signed-off-by: Thomas Stilwell Thomas.Stilwell@nordicsemi.no

@NordicBuilder
Copy link

NordicBuilder commented Jul 13, 2019

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

@thst-nordic
Copy link
Author

These PR's all have very similar changes in order to link the CI plans together: All are passing CI.
nrfconnect/sdk-nrf#979
nrfconnect/sdk-zephyr#174
#45
nrfconnect/sdk-nrfxlib#76

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2019

CLA assistant check
All committers have signed the CLA.

@@ -0,0 +1,6 @@
* 31b475e (HEAD -> add_ci_lib, origin/add_ci_lib) [nrf noup] ci: use Standard Library in Jenkinsfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is surely a mistake?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Jenkinsfile Outdated
body: "${currentBuild.currentResult}\nJob ${env.JOB_NAME}\t\t build ${env.BUILD_NUMBER}\r\nLink: ${env.BUILD_URL}",
subject: "[Jenkins][Build ${currentBuild.currentResult}: ${env.JOB_NAME}]",
mimeType: 'text/html',)
// emailext(to: 'anpu',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with the commented out code?

Copy link
Author

@thst-nordic thst-nordic Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was causing spam during development. Added back in.

@mbolivar
Copy link

These PR's all have very similar changes in order to link the CI plans together: All are passing CI.
NordicPlayground/fw-nrfconnect-nrf#979

This doesn't update the west.yml file to set the mcuboot revision to pull/45/head for testing in CI. Is there another nrf pull request I'm missing here? That is needed just as it is in the zephyr case. In general, any changes to any repository other than nrf itself also need an update to nrf/west.yml.

Please see https://docs.zephyrproject.org/latest/guides/west/repo-tool.html for details.

Managing Docker version, Agent Labels, Github Status,

manifest updates, downstream jobs from CI_LIB.

Signed-off-by: Thomas Stilwell <Thomas.Stilwell@nordicsemi.no>
@thst-nordic
Copy link
Author

pull/45/head was added to the nrf west.yml. and CI passed.
nrfconnect/sdk-nrf@22fd905

Managing Docker version, Agent Labels, Github Status,

manifest updates, downstream jobs from CI_LIB.

Signed-off-by: Thomas Stilwell <Thomas.Stilwell@nordicsemi.no>
@carlescufi carlescufi merged commit ad33e1e into nrfconnect:master Jul 22, 2019
nvlsianpu added a commit to nvlsianpu/fw-nrfconnect-mcuboot that referenced this pull request Feb 8, 2021
Synch up to:
zephyrproject-rtos/mcuboot@360763d

merged by GitHub GUI nrfconnect#45

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants