Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples: Bluetooth: conn time sync fix #17745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HaavardRei
Copy link
Contributor

This commit fixes the following:

  • Fix a bug in the initialization of init_val in the GPIOTE task used for the LED, where it would always be initialized to NRF_GPIOTE_INITIAL_VALUE_HIGH and not take the dt_flags into account. This made the LED toggle with inverted polarity on platforms where the LEDs are active high.
  • Update references to LED numbers in the README to match the actual sample behavior.

@HaavardRei HaavardRei requested review from a team as code owners October 8, 2024 13:29
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 8, 2024
This commit fixes the following:
  * Fix a bug in the initialization of `init_val` in the GPIOTE task
    used for the LED, where it would always be initialized to
    `NRF_GPIOTE_INITIAL_VALUE_HIGH` and not take the dt_flags into
    account. This made the LED toggle with inverted polarity on
    platforms where the LEDs are active high.
  * Update references to LED numbers in the README to match the actual
    sample behavior.

Signed-off-by: Håvard Reierstad <haavard.reierstad@nordicsemi.no>
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 8, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: fed1324417ce4a7d7a88c9d58cc8658b7b9d3fd5

more details

sdk-nrf:

PR head: fed1324417ce4a7d7a88c9d58cc8658b7b9d3fd5
merge base: 4a34c9083a88920d3298f26a0e3058454c1b510d
target head (main): 4a34c9083a88920d3298f26a0e3058454c1b510d
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
samples
│  ├── bluetooth
│  │  ├── conn_time_sync
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ timed_led_toggle.c

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 410
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@HaavardRei HaavardRei added this to the 2.8.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants