Skip to content

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Oct 9, 2024

All nRF Desktop configurations with the DFU over MCUmgr support now require encryption for operations on the Bluetooth SMP service. Unpaired Bluetooth peers should now perform the Bluetooth pairing procedure before the DFU operation.

Ref: NCSDK-29061

@kapi-no kapi-no requested review from a team as code owners October 9, 2024 06:52
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Oct 9, 2024
@kapi-no kapi-no added the DNM label Oct 9, 2024
@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 9, 2024

Adding DNM as it needs additional testing for single-core targets due to the MPSL issues

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 9, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: c27214d98656bb8c4e84cf1cb74cf532e33da672

more details

sdk-nrf:

PR head: c27214d98656bb8c4e84cf1cb74cf532e33da672
merge base: 85dfab5a556022c1f84bc2e542ace42b66edbec4
target head (main): fe37cb7f8389e6e53ce17b7c9b53253520b1ee38
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (11)
applications
│  ├── nrf_desktop
│  │  ├── bootloader_dfu.rst
│  │  ├── configuration
│  │  │  ├── nrf52840dk_nrf52840
│  │  │  │  ├── prj_fast_pair.conf
│  │  │  │  │ prj_mcuboot_smp.conf
│  │  │  ├── nrf52840gmouse_nrf52840
│  │  │  │  ├── prj_fast_pair.conf
│  │  │  │  ├── prj_mcuboot_smp.conf
│  │  │  │  │ prj_release_fast_pair.conf
│  │  │  ├── nrf52kbd_nrf52832
│  │  │  │  │ prj_release_fast_pair.conf
│  │  │  ├── nrf54h20dk_nrf54h20_cpuapp
│  │  │  │  ├── prj.conf
│  │  │  │  │ prj_release.conf
│  │  │  ├── nrf54l15dk_nrf54l15_cpuapp
│  │  │  │  │ prj_fast_pair.conf
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 80
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@kapi-no kapi-no removed the DNM label Oct 9, 2024
@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 9, 2024

Removing the DNM label as I was able to run the missing tests with the following fix:

zephyrproject-rtos/zephyr#79258

@kapi-no kapi-no force-pushed the nrf_desktop_mcumgr_smp_svc_encrypted branch from 220993e to 04bb29f Compare October 9, 2024 07:18
@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 9, 2024

Rebasing to resolve a conflict

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that space is missing before Kconfig option term

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider calling it Bluetooth GATT SMP Service (SMP term has another meaning for Bluetooth)

@kapi-no kapi-no force-pushed the nrf_desktop_mcumgr_smp_svc_encrypted branch from 04bb29f to edd40ad Compare October 9, 2024 08:59
@kapi-no
Copy link
Contributor Author

kapi-no commented Oct 9, 2024

Rebased to fix failing Twister. I haven't addressed the comments yet

@kapi-no kapi-no force-pushed the nrf_desktop_mcumgr_smp_svc_encrypted branch from edd40ad to 4116d76 Compare October 9, 2024 09:04
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

All nRF Desktop configurations with the DFU over MCUmgr support now
require encryption for operations on the Bluetooth SMP service.
Unpaired Bluetooth peers should now perform the Bluetooth pairing
procedure before the DFU operation.

Ref: NCSDK-29061

Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
@kapi-no kapi-no force-pushed the nrf_desktop_mcumgr_smp_svc_encrypted branch from 4116d76 to c27214d Compare October 9, 2024 11:02
@kapi-no kapi-no requested review from a team and divipillai October 9, 2024 11:03
@kapi-no kapi-no added this to the 2.8.0 milestone Oct 9, 2024
@rlubos rlubos merged commit f80548e into nrfconnect:main Oct 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-required PR must not be merged without tech writer approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants