-
Notifications
You must be signed in to change notification settings - Fork 1.4k
applications: nrf_desktop: enable encryption for mcumgr smp service #17764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applications: nrf_desktop: enable encryption for mcumgr smp service #17764
Conversation
Adding DNM as it needs additional testing for single-core targets due to the MPSL issues |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: c27214d98656bb8c4e84cf1cb74cf532e33da672 more detailssdk-nrf:
Github labels
List of changed files detected by CI (11)
Outputs:ToolchainVersion: 6c44240e03 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Removing the DNM label as I was able to run the missing tests with the following fix: |
220993e
to
04bb29f
Compare
Rebasing to resolve a conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that space is missing before Kconfig option
term
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider calling it Bluetooth GATT SMP Service
(SMP term has another meaning for Bluetooth)
04bb29f
to
edd40ad
Compare
Rebased to fix failing Twister. I haven't addressed the comments yet |
edd40ad
to
4116d76
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
All nRF Desktop configurations with the DFU over MCUmgr support now require encryption for operations on the Bluetooth SMP service. Unpaired Bluetooth peers should now perform the Bluetooth pairing procedure before the DFU operation. Ref: NCSDK-29061 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
4116d76
to
c27214d
Compare
All nRF Desktop configurations with the DFU over MCUmgr support now require encryption for operations on the Bluetooth SMP service. Unpaired Bluetooth peers should now perform the Bluetooth pairing procedure before the DFU operation.
Ref: NCSDK-29061