-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Model Publication in Light CTL Temperature Server #19496
Support for Model Publication in Light CTL Temperature Server #19496
Conversation
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. However, commit message needs to follow the format as used by other commits in these files, should be bit more descriptive, and should be signed-off.
514bae5
to
4624730
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@omkar3141's concerns have not been fixed either.
I triggered CI, please take a look at the compliance bugs. They have to be fixed.
Please rebase at the latest main to avoid another issues.
Hello, any updates on this PR? I agree about |
Hi, just set down to propperly write the commit messages with attribution |
9259171
to
fdadecb
Compare
Sorry about the delay, struggled a bit with amending the commit messages correctly whilst conforming to the contribution guidelines. I messed up with the built in attribution of Alex, but added him as co-author to the commit. Hope that is fine. |
14acca0
to
95cf766
Compare
Implemented model publication as specified in Mesh Model Specification v1.0.1, Section 6.4.4.1. Implemented similar to other publication services in Bt Mesh. Tested in company own testing environment. Co-authored-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no> Signed-off-by: Ilija Vorontsov <ilija.vorontsov@loytec.com>
95cf766
to
83fe35d
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 83fe35d8e1e223a1d05818b160df68158993652c more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Specification Requirements
| From the Mesh Model Specification v1.0.1, Section 6.4.4.1:
This model shall support model publication, as defined in Section 4.2.2 of the Mesh Profile specification.
The Mesh Profile Specification v1.0.1, Section 4.2.2 defines model publication as a composite state that controls message publishing parameters, including:
Publish Address
Publish Period
Retransmission Settings
Implementation Approach
The implementation adds publication support following the same pattern established in the light_ctl_srv, ensuring consistency with existing model implementations while fulfilling the specification's requirements. This approach maintains architectural coherence within the Bluetooth mesh stack.