application: serial_lte_modem: Multiple socket support #19929
+207
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current solution .SLM manages all opened sockets for MCU .use #XSOCKETSELECT to switch active socket .only one active socket New solution .MCU manages all opened socket .Remove #XSOCKETSELECT .multiple active sockets Signed-off-by: Jun Qing Zou <jun.qing.zou@nordicsemi.no>
github-actions
bot
added
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:more detailsGithub labels
List of changed files detected by CI (0)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
ATTN: this is only a draft PR from customer requirement of supporting multiple sockets simultaneously, which is possible with Nordic competitors. There is no need of reviewing for NCS integretion as of now. |
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
MarkusLassila
requested changes
Jan 16, 2025
| @@ -1017,9 +988,12 @@ static int handle_at_socket(enum at_parser_cmd_type cmd_type, struct at_parser * | |||
| } break; | |||
There was a problem hiding this comment.
You need ability to close a specific socket. Likely it could be a different AT-command.
There was a problem hiding this comment.
Suggestions:
- sockopt_get and sec_sockopt_get should likely print out the socket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current solution
.SLM manages all opened sockets for MCU
.use #XSOCKETSELECT to switch active socket
.only one active socket
New solution
.MCU manages all opened socket
.Remove #XSOCKETSELECT
.multiple active sockets