Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootloader: Use proper CR-LF end line chars #19955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fundakol
Copy link
Contributor

This fix helps to test UART output from board.

@fundakol fundakol requested a review from a team as a code owner January 16, 2025 13:42
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 16, 2025
@fundakol fundakol requested a review from nvlsianpu January 16, 2025 13:42
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 16, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: e7d30f99f0aa868af55f46d8e664d79056d9e153

more details

sdk-nrf:

PR head: e7d30f99f0aa868af55f46d8e664d79056d9e153
merge base: 35facd192a4afb59ad952ea253e7307829c52c59
target head (main): 4389cc31d0f31cd2efe5aa851fcb65ffeaa3f30f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
samples
│  ├── bootloader
│  │  ├── src
│  │  │  │ main.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 87
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-boot
    • ❌ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n\r is wrong

  • Windows: \r\n
  • Linux/mac: \n
  • There is no \n\r except for mac 15+ years ago or some incredibly specific tiny OS's

@fundakol
Copy link
Contributor Author

\n\r is wrong

* Windows: `\r\n`

* Linux/mac: `\n`

* There is no `\n\r` except for mac 15+ years ago or some incredibly specific tiny OS's

I messed this up. You have right. There is mix of \r\n and \n\r in the code and my intention was to fix \n\r, but somehow I made a mistake replacing it.
I will fix it.

This fix helps to test UART output from board.

Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants