Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: Bluetooth: update scanning_while_connecting sample #19976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

samples: Bluetooth: update scanning_while_connecting sample #19976

wants to merge 1 commit into from

Conversation

henrla
Copy link
Contributor

@henrla henrla commented Jan 17, 2025

Update bluetooth softdevice controller configuration to achieve faster connection establishment.

@henrla henrla requested review from a team as code owners January 17, 2025 13:49
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 17, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 17, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 145a6ffb8850ac8d06295b2929fd7708c4f990ef

more details

sdk-nrf:

PR head: 145a6ffb8850ac8d06295b2929fd7708c4f990ef
merge base: 8fde9ff93d495f0ea17f942bdeae2ae6bdc54f78
target head (main): 8fdaf7ee6259055f370eb3b14ca221da73668622
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
samples
│  ├── bluetooth
│  │  ├── scanning_while_connecting
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 479
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

rugeGerritsen
rugeGerritsen reviewed Jan 17, 2025
View reviewed changes
samples/bluetooth/scanning_while_connecting/src/main.c Outdated
.event_length_us = 2000,
};

sdc_hci_cmd_vs_event_length_set(&event_length_params);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we should use

Suggested change
sdc_hci_cmd_vs_event_length_set(&event_length_params);
hci_vs_sdc_event_length_set(&event_length_params);

instead so that the code is portable to multicore devices

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@henrla
samples: Bluetooth: update scanning_while_connecting sample
145a6ff 
Update bluetooth softdevice controller configuration
to achieve faster connection establishment.

Signed-off-by: Henrik Lander <henrik.lander@nordicsemi.no>
@henrla henrla force-pushed the update_scanning_while_connecting_sample branch from 4783bfb to 145a6ff Compare January 17, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rugeGerritsen rugeGerritsen rugeGerritsen approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrla @NordicBuilder @rugeGerritsen