Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Optimized LIT configuration #20079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kkasperczyk-no
Copy link
Contributor

The LIT configuration in Matter samples can be slightly changed to achieve lower power consumption.

Additionally, added piece of documentation explaining how to configure the radio driver calibration period.

@kkasperczyk-no kkasperczyk-no requested review from a team as code owners January 27, 2025 08:16
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 27, 2025
@kkasperczyk-no kkasperczyk-no requested a review from a team January 27, 2025 08:17
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 27, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 6af29dbffb81702ce73a7135abd90fcf90dcd8c1

more details

sdk-nrf:

PR head: 6af29dbffb81702ce73a7135abd90fcf90dcd8c1
merge base: 1aed4564bcee2393536df83365b474800166ccf9
target head (main): 0a56342ad66c274e2b9d3ca6bed5dfc8d8793bd0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
doc
│  ├── nrf
│  │  ├── protocols
│  │  │  ├── matter
│  │  │  │  ├── getting_started
│  │  │  │  │  │ low_power_configuration.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── matter
│  │  ├── light_switch
│  │  │  ├── snippets
│  │  │  │  ├── lit_icd
│  │  │  │  │  │ lit_icd.conf
│  │  ├── smoke_co_alarm
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 92
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@kkasperczyk-no kkasperczyk-no force-pushed the low_power_optimizations branch 2 times, most recently from a17e115 to 8232d52 Compare January 27, 2025 08:36
@kkasperczyk-no kkasperczyk-no force-pushed the low_power_optimizations branch from 8232d52 to 8e9b649 Compare January 27, 2025 09:00
@kkasperczyk-no kkasperczyk-no requested a review from peknis January 28, 2025 06:46
Copy link
Contributor

@peknis peknis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a nit.

@kkasperczyk-no kkasperczyk-no force-pushed the low_power_optimizations branch 2 times, most recently from a859ece to bf55311 Compare January 28, 2025 09:18
@kkasperczyk-no kkasperczyk-no requested a review from a team as a code owner January 28, 2025 09:18
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 28, 2025
@kkasperczyk-no kkasperczyk-no force-pushed the low_power_optimizations branch from bf55311 to f45b021 Compare January 28, 2025 09:28
@kkasperczyk-no kkasperczyk-no force-pushed the low_power_optimizations branch from f45b021 to 4a523ff Compare January 28, 2025 09:42
@kkasperczyk-no
Copy link
Contributor Author

@nrfconnect/ncs-co-build-system please review

Comment on lines +25 to +31
# Use the same value as CONFIG_CHIP_ICD_IDLE_MODE_DURATION
config CHIP_ICD_SLOW_POLL_INTERVAL
default 300000

# Use greater than default (200 ms) value to limit the impact of Active Threshold Duration on power consumption
config CHIP_ICD_FAST_POLLING_INTERVAL
default 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you setting defaults in a Kconfig file? These should be in a prj.conf file...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall idea was to keep the configs common to all variants (in case of having multiple prj.confs) in Kconfig, to avoid copying it across multiple files. I can move this one now, but please note that there are already other configs configured in the same way, so it will result in inconsistency and I would not like to refactor all samples in scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please request changing the way how Matter samples are configured in a separate ticket, if you find it necessary. This PR only changes two values, so I don't want to bring the inconsistency or increase the scope.

The LIT configuration in Matter samples can be slightly changed
to achieve lower power consumption.

Additionally, added piece of documentation explaining how to
configure the radio driver calibration period.

Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
@kkasperczyk-no kkasperczyk-no force-pushed the low_power_optimizations branch from 4a523ff to 6af29db Compare February 19, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants