-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: matter: Optimized LIT configuration #20079
base: main
Are you sure you want to change the base?
samples: matter: Optimized LIT configuration #20079
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 6af29dbffb81702ce73a7135abd90fcf90dcd8c1 more detailssdk-nrf:
Github labels
List of changed files detected by CI (4)
Outputs:ToolchainVersion: 4cff34261a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
a17e115
to
8232d52
Compare
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
8232d52
to
8e9b649
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a nit.
doc/nrf/protocols/matter/getting_started/low_power_configuration.rst
Outdated
Show resolved
Hide resolved
a859ece
to
bf55311
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
bf55311
to
f45b021
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
f45b021
to
4a523ff
Compare
@nrfconnect/ncs-co-build-system please review |
# Use the same value as CONFIG_CHIP_ICD_IDLE_MODE_DURATION | ||
config CHIP_ICD_SLOW_POLL_INTERVAL | ||
default 300000 | ||
|
||
# Use greater than default (200 ms) value to limit the impact of Active Threshold Duration on power consumption | ||
config CHIP_ICD_FAST_POLLING_INTERVAL | ||
default 500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you setting defaults in a Kconfig file? These should be in a prj.conf file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall idea was to keep the configs common to all variants (in case of having multiple prj.confs) in Kconfig, to avoid copying it across multiple files. I can move this one now, but please note that there are already other configs configured in the same way, so it will result in inconsistency and I would not like to refactor all samples in scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please request changing the way how Matter samples are configured in a separate ticket, if you find it necessary. This PR only changes two values, so I don't want to bring the inconsistency or increase the scope.
The LIT configuration in Matter samples can be slightly changed to achieve lower power consumption. Additionally, added piece of documentation explaining how to configure the radio driver calibration period. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
4a523ff
to
6af29db
Compare
The LIT configuration in Matter samples can be slightly changed to achieve lower power consumption.
Additionally, added piece of documentation explaining how to configure the radio driver calibration period.