Skip to content

modules: wfa-qt: Fix server certificate validation #25220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

modules: wfa-qt: Fix server certificate validation #25220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4838aaf
manifest: sdk-zephyr: Pull server validation changes
D-Triveni Nov 7, 2025
9f029d8
modules: wfa-qt: Fix server certificate validation
D-Triveni Oct 24, 2025
b523b3f
modules: wfa-qt: Fix build error
D-Triveni Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 34 additions & 8 deletions modules/wfa-qt/src/indigo_api_callback_dut.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ static int handle_response(char *buffer, char *response)

static int run_qt_command(const char *cmd)
{
struct wpa_supplicant *wpa_s;
char buffer[64] = { 0 }, response[16] = { 0 };
size_t resp_len = sizeof(response);
int ret = 0;
Expand All @@ -152,8 +153,9 @@ static int run_qt_command(const char *cmd)
goto done;
}

if (ctrl_conn) {
ret = wpa_ctrl_request(ctrl_conn, buffer, sizeof(buffer),
wpa_s = zephyr_get_handle_by_ifname(CONFIG_WFA_QT_DEFAULT_INTERFACE);
if (wpa_s && wpa_s->ctrl_conn) {
ret = wpa_ctrl_request(wpa_s->ctrl_conn, buffer, sizeof(buffer),
response, &resp_len, NULL);
if (ret) {
indigo_logger(LOG_LEVEL_ERROR,
Expand All @@ -169,7 +171,13 @@ static int run_qt_command(const char *cmd)
if (ret < 0) {
goto done;
}
} else {
indigo_logger(LOG_LEVEL_ERROR,
"WPA Supplicant ready event received, but no handle found for %s",
CONFIG_WFA_QT_DEFAULT_INTERFACE);
return -1;
}

indigo_logger(LOG_LEVEL_DEBUG, "Response: %s", response);
return 0;
done:
Expand Down Expand Up @@ -1864,8 +1872,16 @@ static int configure_sta_handler(struct packet_wrapper *req, struct packet_wrapp
"SET_NETWORK 0 psk \"%s\"", psk);
ret = run_qt_command(buffer);
CHECK_RET();
ret = run_qt_command("SET_NETWORK 0 ieee80211w 1");
CHECK_RET();
tlv = find_wrapper_tlv_by_id(req, TLV_STA_IEEE80211_W);
if (tlv) {
CHECK_SNPRINTF(buffer, sizeof(buffer), ret,
"SET_NETWORK 0 ieee80211w %s", tlv->value);
ret = run_qt_command(buffer);
CHECK_RET();
} else {
ret = run_qt_command("SET_NETWORK 0 ieee80211w 0");
CHECK_RET();
}
} else if (strstr(tlv->value, "SAE")) {
CHECK_SNPRINTF(buffer, sizeof(buffer), ret,
"SET_NETWORK 0 sae_password \"%s\"", psk);
Expand All @@ -1881,6 +1897,11 @@ static int configure_sta_handler(struct packet_wrapper *req, struct packet_wrapp

process_certificates();

if (strstr(tlv->value, "WPA-EAP-SHA256")) {
ret = run_qt_command("SET_NETWORK 0 ieee80211w 2");
CHECK_RET();
}

struct {
int tlv_id;
const char *cmd_fmt;
Expand Down Expand Up @@ -1911,6 +1932,15 @@ static int configure_sta_handler(struct packet_wrapper *req, struct packet_wrapp
{ TLV_PASSWORD,
"SET_NETWORK 0 password \"%s\"",
NULL, true },
{ TLV_STA_IEEE80211_W,
"SET_NETWORK 0 ieee80211w %s",
NULL, true },
{ TLV_DOMAIN_MATCH,
"SET_NETWORK 0 domain_match \"%s\"",
NULL, true },
{ TLV_DOMAIN_SUFFIX_MATCH,
"SET_NETWORK 0 domain_suffix_match \"%s\"",
NULL, true },
};

for (size_t i = 0; i < ARRAY_SIZE(config_cmds); i++) {
Expand All @@ -1930,10 +1960,6 @@ static int configure_sta_handler(struct packet_wrapper *req, struct packet_wrapp
}
}

ret = run_qt_command(buffer);
CHECK_RET();
ret = run_qt_command("SET_NETWORK 0 ieee80211w 1");
CHECK_RET();
}
#else
}
Expand Down
2 changes: 1 addition & 1 deletion west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ manifest:
# https://developer.nordicsemi.com/nRF_Connect_SDK/doc/latest/zephyr/guides/modules.html
- name: zephyr
repo-path: sdk-zephyr
revision: 5ce544de9868ac2bb919b608b7b3e8d0c443f34f
revision: pull/3478/head
import:
# In addition to the zephyr repository itself, NCS also
# imports the contents of zephyr/west.yml at the above
Expand Down
Loading