samples: crypto: add support for nrf7120 samples #25357

travis3630 · 2025-10-31T14:36:52Z

Add support for nrf7120pdk_nrf7120_cpuapp to all samples support nrf7120

degjorva · 2025-10-31T14:42:25Z

samples/crypto/kmu_usage_nrf54l/README.rst

 .. table-from-rows:: /includes/sample_board_rows.txt
   :header: heading
-   :rows: nrf54l15dk_nrf54l05_cpuapp, nrf54l15dk_nrf54l10_cpuapp, nrf54l15dk_nrf54l15_cpuapp, nrf54l15dk_nrf54l15_cpuapp_ns, nrf54lm20dk_nrf54lm20a_cpuapp, nrf54lv10dk_nrf54lv10a_cpuapp
+   :rows: nrf54l15dk_nrf54l05_cpuapp, nrf54l15dk_nrf54l10_cpuapp, nrf54l15dk_nrf54l15_cpuapp, nrf54l15dk_nrf54l15_cpuapp_ns, nrf54lm20dk_nrf54lm20a_cpuapp, nrf54lv10dk_nrf54lv10a_cpuapp, nrf7120pdk_nrf7120p_cpuapp


Well the naming of the sample was correct for two weeks at least. That is something

Hmm, I don't get what that means. Do you mean this sample name is kmu_sage_nrf54l but included nrf7120 should be some new name or?

Yeah. Please rename the sample and any reference to it being 54L only. cc @AntonZma

NordicBuilder · 2025-10-31T14:43:00Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: f532d63e92ca85ca9f7b3dc3926cb9060be53a75

more details

sdk-nrf:

PR head: f532d63e92ca85ca9f7b3dc3926cb9060be53a75
merge base: 36da4576a816545f77219f783d06a0e2d164888a
target head (main): ac58534521844f00ba3f70f8514d2d20b6a7277d
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (38)

boards
│  ├── nordic
│  │  ├── nrf7120pdk
│  │  │  │ nrf7120pdk_nrf7120_cpuapp_defconfig
samples
│  ├── crypto
│  │  ├── aes_cbc
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── aes_ccm
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── aes_ctr
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── aes_gcm
│  │  │  │ sample.yaml
│  │  ├── chachapoly
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── ecdh
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── ecdsa
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── ecjpake
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── eddsa
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── hkdf
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── hmac
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── kmu_usage_nrf54l
│  │  │  ├── README.rst
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── pbkdf2
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── persistent_key_usage
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── rng
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── rsa
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── sha256
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
│  │  ├── spake2p
│  │  │  ├── boards
│  │  │  │  │ nrf7120pdk_nrf7120_cpuapp.conf
│  │  │  │ sample.yaml
tests
│  ├── psa_crypto
│  │  │ testcase.yaml

Outputs:

Toolchain

Version: cfa6b06338
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:cfa6b06338_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 904
✅ Integration tests
- ✅ test-fw-nrfconnect-nrf_crypto
- ✅ test-secdom-samples-public

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-wifi

Note: This message is automatically posted and updated by the CI

github-actions · 2025-10-31T16:23:52Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-25357/nrf/samples/crypto/kmu_usage_nrf54l/README.html

tomi-font

Release notes entry?

greg-fer

Also add a changelog entry for the sample mentioning added support for a new device.

samples/crypto/persistent_key_usage/boards/nrf7120pdk_nrf7120_cpuapp.conf

samples/crypto/rsa/boards/nrf7120pdk_nrf7120_cpuapp.conf

samples/crypto/rng/boards/nrf7120pdk_nrf7120_cpuapp.conf

samples/crypto/pbkdf2/boards/nrf7120pdk_nrf7120_cpuapp.conf

samples/crypto/hmac/boards/nrf7120pdk_nrf7120_cpuapp.conf

samples/crypto/hkdf/boards/nrf7120pdk_nrf7120_cpuapp.conf

samples/crypto/kmu_usage_nrf54l/README.rst

greg-fer · 2025-11-03T13:28:04Z

samples/crypto/kmu_usage_nrf54l/README.rst

+   :rows: nrf54l15dk_nrf54l05_cpuapp, nrf54l15dk_nrf54l10_cpuapp, nrf54l15dk_nrf54l15_cpuapp, nrf54l15dk_nrf54l15_cpuapp_ns, nrf54lm20dk_nrf54lm20a_cpuapp, nrf54lv10dk_nrf54lv10a_cpuapp, nrf7120pdk_nrf7120_cpuapp

 .. include:: /includes/tfm.txt



In addition to edits to this README, you also need to update the following docs in time for the launch of nRF7120:

https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/app_dev/device_guides/nrf54l/cryptography.rst with information about 7120; the page needs to be moved out of nRF54L section as part of this task

https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/app_dev/device_guides/nrf54l/kmu_provision.rst with information about 7120; the page needs to be moved out of nRF54L section as part of this task

Can you please sync with your team's tech writer and create a task for this?

WZN-7049 has been created for this.

Add support for nrf7120pdk_nrf7120_cpuapp to all samples support nrf7120 Signed-off-by: Travis Lam <travis.lam@nordicsemi.no>

samples/crypto/kmu_usage_nrf54l/README.rst

greg-fer · 2025-11-04T07:46:46Z

samples/crypto/kmu_usage_nrf54l/sample.yaml

      - nrf54l15dk/nrf54l10/cpuapp
      - nrf54l15dk/nrf54l10/cpuapp/ns
      - nrf54l15dk/nrf54l05/cpuapp
+      - nrf7120pdk/nrf7120/cpuapp


name in line 6 of this file needs to be updated, given your added support for nRF7120.

Do I need to update the name of the folder? to kmu_usage remove nrf54l only?

You can't use kmu_usage, as 5340 is not supported. You will need a generic name for 54l + 71

54l + 71 == 125l

Jokes apart, if we need a name to distinguish from 5340 let's maybe go with lumos?

It is what we use for the upstream Kconfig so it would make sense. I also think kmu_usage_everything_except_5340 rolls off the tongue well

Or kmu_usage_for_the_newer_kmu_peripheral?

kmu_usage_^nrf(54|71)[a-z]*\d+[a-z]*$ simple and easy to understand

greg-fer · 2025-11-04T07:51:01Z

samples/crypto/kmu_usage_nrf54l/README.rst

      nrfutil device erase --all

-#. :ref:`Program <programming>` the sample to your nRF54L Series device.
+#. :ref:`Program <programming>` the sample to your nRF54L Series and nRF7120 device.


Suggested change

#. :ref:`Program <programming>` the sample to your nRF54L Series and nRF7120 device.

#. :ref:`Program <programming>` the sample to your nRF54L Series or nRF7120 device.

Sorry, my mistake from first suggestion :)

Do we even need to specify the device here? Can't we just say "to your device"?

tomi-font

Are you also planning to add 7120 NS?

tomi-font · 2025-11-04T11:17:10Z

samples/crypto/kmu_usage_nrf54l/README.rst

   :depth: 2

-The KMU usage sample demonstrates how to generate cryptographic keys for nRF54L Series devices and securely store them in the Key Management Unit (KMU).
+The KMU usage sample demonstrates how to generate cryptographic keys for nRF54L Series devices and nRF7120 and securely store them in the Key Management Unit (KMU).


Phrasing seems a bit awkward, maybe rework the structure?

Suggested change

The KMU usage sample demonstrates how to generate cryptographic keys for nRF54L Series devices and nRF7120 and securely store them in the Key Management Unit (KMU).

The KMU usage sample demonstrates how to generate cryptographic keys and securely store them in the Key Management Unit (KMU) on nRF54L Series and nRF7120 devices.

7120 NS maybe in the next PR, to reduce the complexity of this PR?

tomi-font · 2025-11-04T11:18:11Z

samples/crypto/kmu_usage_nrf54l/README.rst

      nrfutil device erase --all

-#. :ref:`Program <programming>` the sample to your nRF54L Series device.
+#. :ref:`Program <programming>` the sample to your nRF54L Series and nRF7120 device.


Do we even need to specify the device here? Can't we just say "to your device"?

tomi-font · 2025-11-04T11:18:40Z

samples/crypto/kmu_usage_nrf54l/sample.yaml

      - ".*Example finished successfully!.*"

 tests:
  sample.kmu_usage_nrf54l:


here too needs renaming

ioannisg

Pls ignore my comments :)

rob-robinson-14 · 2025-11-04T16:53:08Z

boards/nordic/nrf7120pdk/nrf7120pdk_nrf7120_cpuapp_defconfig

 CONFIG_NRF_GRTC_START_SYSCOUNTER=y
-
-# Temporarily disable whilst resolving issue with CI
-CONFIG_CRACEN_LIB_KMU=n


Please wait for https://jenkins-ncs.nordicsemi.no/job/latest/job/test-zephyr-sanitycheck-self-verification/view/change-requests/job/PR-2990/ to be merged before making this change

rob-robinson-14 · 2025-11-04T16:57:48Z

samples/crypto/kmu_usage_nrf54l/README.rst

+   :rows: nrf54l15dk_nrf54l05_cpuapp, nrf54l15dk_nrf54l10_cpuapp, nrf54l15dk_nrf54l15_cpuapp, nrf54l15dk_nrf54l15_cpuapp_ns, nrf54lm20dk_nrf54lm20a_cpuapp, nrf54lv10dk_nrf54lv10a_cpuapp, nrf7120pdk_nrf7120_cpuapp

 .. include:: /includes/tfm.txt



WZN-7049 has been created for this.

travis3630 requested review from a team, Hi-Im-David and rob-robinson-14 as code owners October 31, 2025 14:36

NordicBuilder added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 31, 2025

degjorva approved these changes Oct 31, 2025

View reviewed changes

travis3630 force-pushed the WZN-5115-add-CRACEN-crypto-sample-tests branch from 435b87b to 6f04b65 Compare October 31, 2025 15:39

NordicBuilder requested a review from a team October 31, 2025 15:40

tomi-font reviewed Nov 3, 2025

View reviewed changes

greg-fer requested changes Nov 3, 2025

View reviewed changes

samples: crypto: add support for nrf7120 samples

f532d63

Add support for nrf7120pdk_nrf7120_cpuapp to all samples support nrf7120 Signed-off-by: Travis Lam <travis.lam@nordicsemi.no>

travis3630 force-pushed the WZN-5115-add-CRACEN-crypto-sample-tests branch from 6f04b65 to f532d63 Compare November 3, 2025 16:12

NordicBuilder requested review from a team November 3, 2025 16:12

ioannisg reviewed Nov 3, 2025

View reviewed changes

samples/crypto/kmu_usage_nrf54l/README.rst Show resolved Hide resolved

ioannisg reviewed Nov 3, 2025

View reviewed changes

samples/crypto/kmu_usage_nrf54l/README.rst Show resolved Hide resolved

ioannisg reviewed Nov 3, 2025

View reviewed changes

samples/crypto/kmu_usage_nrf54l/README.rst Show resolved Hide resolved

greg-fer requested changes Nov 4, 2025

View reviewed changes

tomi-font reviewed Nov 4, 2025

View reviewed changes

ioannisg approved these changes Nov 4, 2025

View reviewed changes

rob-robinson-14 reviewed Nov 4, 2025

View reviewed changes

		:rows: nrf54l15dk_nrf54l05_cpuapp, nrf54l15dk_nrf54l10_cpuapp, nrf54l15dk_nrf54l15_cpuapp, nrf54l15dk_nrf54l15_cpuapp_ns, nrf54lm20dk_nrf54lm20a_cpuapp, nrf54lv10dk_nrf54lv10a_cpuapp, nrf7120pdk_nrf7120_cpuapp

		.. include:: /includes/tfm.txt

	#. :ref:`Program <programming>` the sample to your nRF54L Series and nRF7120 device.
	#. :ref:`Program <programming>` the sample to your nRF54L Series or nRF7120 device.

	The KMU usage sample demonstrates how to generate cryptographic keys for nRF54L Series devices and nRF7120 and securely store them in the Key Management Unit (KMU).
	The KMU usage sample demonstrates how to generate cryptographic keys and securely store them in the Key Management Unit (KMU) on nRF54L Series and nRF7120 devices.

samples: crypto: add support for nrf7120 samples #25357

Are you sure you want to change the base?

samples: crypto: add support for nrf7120 samples #25357

Uh oh!

Conversation

travis3630 commented Oct 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

tomi-font left a comment

Choose a reason for hiding this comment

Uh oh!

greg-fer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomi-font left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomi-font Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NordicBuilder commented Oct 31, 2025 •

edited

Loading

tomi-font Nov 4, 2025 •

edited

Loading