Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: nrf_modem: deprecate init ret function #8380

Merged
merged 1 commit into from
Sep 9, 2022
Merged

lib: nrf_modem: deprecate init ret function #8380

merged 1 commit into from
Sep 9, 2022

Conversation

MirkoCovizzi
Copy link
Contributor

This commit deprecates the nrf_modem_lib_get_init_ret function
in favor of init hooks.

Signed-off-by: Mirko Covizzi mirko.covizzi@nordicsemi.no

@MirkoCovizzi MirkoCovizzi self-assigned this Aug 11, 2022
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Aug 11, 2022
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@eivindj-nordic eivindj-nordic self-requested a review August 11, 2022 11:53
jayteemo
jayteemo suggested changes Aug 11, 2022
View reviewed changes
samples/nrf9160/nrf_cloud_rest_fota/src/main.c Outdated Show resolved Hide resolved
samples/nrf9160/nrf_cloud_rest_fota/src/main.c Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_fota_common.c Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_fota_common.c Outdated Show resolved Hide resolved
subsys/net/lib/nrf_cloud/src/nrf_cloud_fota_common.c Outdated Show resolved Hide resolved
samples/nrf9160/nrf_cloud_rest_fota/src/main.c Outdated Show resolved Hide resolved
samples/nrf9160/nrf_cloud_rest_device_message/src/main.c Outdated Show resolved Hide resolved
samples/nrf9160/nrf_cloud_rest_device_message/src/main.c Outdated Show resolved Hide resolved
samples/nrf9160/nrf_cloud_rest_device_message/src/main.c Outdated Show resolved Hide resolved
@MirkoCovizzi MirkoCovizzi requested a review from jayteemo August 15, 2022 08:26
jayteemo
jayteemo reviewed Aug 15, 2022
View reviewed changes
subsys/net/lib/lwm2m_client_utils/lwm2m/lwm2m_firmware.c Outdated
struct update_counter counter;

/* Handle return values relating to modem firmware update */
ret = modem_lib_init_result;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ret = modem_lib_init_result;
int ret = modem_lib_init_result;

glarsennordic
glarsennordic approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@glarsennordic glarsennordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just definitely include that change suggested by @jayteemo

eivindj-nordic
eivindj-nordic reviewed Aug 26, 2022
View reviewed changes
Copy link
Contributor

@eivindj-nordic eivindj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
There is one occurrence in the azure_fota sample that is yet to be addressed in addition to the lwm2m library.

trantanen
trantanen approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modem shell looks fine

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 1, 2022 •
edited
Loading

Integration test specification

Test Module File based changes Manually selected West overwrite
test-ci-nrfconnect-boot-fw-update X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-sdk-homekit X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@lemrey
Copy link
Contributor

lemrey commented Sep 1, 2022

Changes look fine, but we need a changelog entry for this.

simensrostad
simensrostad approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@simensrostad simensrostad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tokangas
tokangas approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@tokangas tokangas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine from modem_shell point of view.

@MirkoCovizzi MirkoCovizzi added this to the 2.1.0 milestone Sep 2, 2022
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 2, 2022
divipillai
divipillai approved these changes Sep 2, 2022
View reviewed changes
doc/nrf/releases/release-notes-changelog.rst Outdated
Comment on lines 682 to 686
* Deprecated:

* The following functions:

* ``nrf_modem_lib_get_init_ret``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Deprecated:
* The following functions:
* ``nrf_modem_lib_get_init_ret``
* Deprecated the ``nrf_modem_lib_get_init_ret`` function.

junqingzou
junqingzou approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@junqingzou junqingzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLM update LGTM

lemrey
lemrey approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@lemrey lemrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@greg-fer greg-fer mentioned this pull request Sep 6, 2022
Merged
14 tasks
@MirkoCovizzi
lib: nrf_modem: deprecate init ret function
97ba878 
This commit deprecates the `nrf_modem_lib_get_init_ret` function
in favor of init hooks.

Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
@rlubos
Copy link
Contributor

rlubos commented Sep 9, 2022

Thingy91 tests have finally passed, merging.

@rlubos rlubos merged commit f760076 into nrfconnect:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glarsennordic glarsennordic glarsennordic approved these changes

@divipillai divipillai divipillai approved these changes

@eivindj-nordic eivindj-nordic eivindj-nordic approved these changes

@trantanen trantanen trantanen approved these changes

@simensrostad simensrostad simensrostad approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

@junqingzou junqingzou junqingzou approved these changes

@jayteemo jayteemo jayteemo approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@tokangas tokangas tokangas approved these changes

@lemrey lemrey lemrey approved these changes

@plskeggs plskeggs plskeggs approved these changes

@rlubos rlubos Awaiting requested review from rlubos

@anangl anangl Awaiting requested review from anangl

@jheiskan81 jheiskan81 Awaiting requested review from jheiskan81

@jtguggedal jtguggedal Awaiting requested review from jtguggedal

@jhn-nordic jhn-nordic Awaiting requested review from jhn-nordic

@coderbyheart coderbyheart Awaiting requested review from coderbyheart

@hiltunent hiltunent Awaiting requested review from hiltunent

@jhirsi jhirsi Awaiting requested review from jhirsi

@pirun pirun Awaiting requested review from pirun

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees

@MirkoCovizzi MirkoCovizzi

Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.