Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: nrf5340_audio: updated manifest and removed group filter #8673

Merged
merged 2 commits into from
Sep 8, 2022
Merged

applications: nrf5340_audio: updated manifest and removed group filter #8673

merged 2 commits into from
Sep 8, 2022

Conversation

koffes
Copy link
Contributor

@koffes koffes commented Sep 8, 2022

Preparing for making LC3 repo public

Signed-off-by: Kristoffer Rist Skøien kristoffer.skoien@nordicsemi.no

@koffes koffes added the DNM label Sep 8, 2022
@github-actions github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest labels Sep 8, 2022
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 8, 2022 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@ee0d1c6 nrfconnect/sdk-nrfxlib@9a6637e (main) nrfconnect/sdk-nrfxlib@ee0d1c66..9a6637e1
sdk-lc3 https://github.com/nrfconnect/sdk-lc3/commit/c47d9ee21c9cd8626a903c2e2f0c80c0920a1eb8 N/A N/A

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@rlubos rlubos added this to the 2.1.0 milestone Sep 8, 2022
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@koffes koffes force-pushed the lc3-update branch 4 times, most recently from 8b812e3 to 09e3c0c Compare September 8, 2022 09:45
tejlmand
tejlmand approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlescufi carlescufi mentioned this pull request Sep 8, 2022
Merged
@koffes koffes requested a review from greg-fer September 8, 2022 11:55
@greg-fer greg-fer added the doc-required PR must not be merged without tech writer approval. label Sep 8, 2022
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 8, 2022 •
edited
Loading

Integration test specification

Test Module File based changes Manually selected West overwrite
test-sdk-audio X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

koffes
koffes commented Sep 8, 2022
View reviewed changes
Copy link
Contributor Author

@koffes koffes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

erikrobstad
erikrobstad approved these changes Sep 8, 2022
View reviewed changes
applications/nrf5340_audio/README.rst Outdated Show resolved Hide resolved
greg-fer
greg-fer approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving my own edits :)

rick1082
rick1082 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@rick1082 rick1082 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with NCS Toolchain manager on Windows with fetching this PR.

@greg-fer greg-fer mentioned this pull request Sep 8, 2022
Merged
14 tasks
rlubos
rlubos reviewed Sep 8, 2022
View reviewed changes
west.yml Outdated
@@ -112,7 +112,7 @@ manifest:
- name: nrfxlib
repo-path: sdk-nrfxlib
path: nrfxlib
revision: ee0d1c66944f15a47d08883c4826b3b4b4cb317e
revision: pull/826/head
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update SHA: 9a6637e12575807dc4f6843acc14cc78de4601d5

@rlubos rlubos mentioned this pull request Sep 8, 2022
Closed
koffes and others added 2 commits September 8, 2022 16:46
@koffes
applications: nrf5340_audio: updated manifest and removed group filter
21e8cdb 
Move LC3 library to nrfxlib

Signed-off-by: Kristoffer Rist Skøien <kristoffer.skoien@nordicsemi.no>
Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
Signed-off-by: Kristoffer Rist Skøien <kristoffer.skoien@nordicsemi.no>
@greg-fer @koffes
doc: nrf5340audio: rephrase mentions of lc3
8cb05ab 
Edited lines about LC3 codec, given its integration into nrfxlib.

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>
@NordicBuilder NordicBuilder removed the DNM label Sep 8, 2022
@rlubos
Copy link
Contributor

rlubos commented Sep 8, 2022

For some reason the CI status was not updated here, but the latest job passed on Jenkins (https://jenkins-ncs.nordicsemi.no/job/latest/job/sdk-nrf/job/PR-8673/8/), merging.

@rlubos rlubos merged commit 731d24b into nrfconnect:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikrobstad erikrobstad erikrobstad approved these changes

@greg-fer greg-fer greg-fer approved these changes

@rick1082 rick1082 rick1082 approved these changes

@rlubos rlubos rlubos approved these changes

@carlescufi carlescufi carlescufi approved these changes

@tejlmand tejlmand tejlmand approved these changes

@alexsven alexsven Awaiting requested review from alexsven

@gWacey gWacey Awaiting requested review from gWacey

@nordic-auko nordic-auko Awaiting requested review from nordic-auko

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest manifest-nrfxlib manifest-sdk-lc3
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
8 participants
@koffes @NordicBuilder @rlubos @tejlmand @carlescufi @rick1082 @greg-fer @erikrobstad