Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset_tracker_v2: Increase memfault event storage buffer size #8743

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

balaji-srin
Copy link

Increase the memfault event storage buffer size so that all metrics generated by the application can be stored and forwarded to memfault cloud. The default value (1024) results in memfault event storage becoming full every 15 minutes.

Tested by running the application for over 90 minutes and found that the error "mflt: Event storage full" is no longer printed.

CIA-769

Signed-off-by: Balaji Srinivasan balaji.srinivasan@nordicsemi.no
Signed-off-by: Simen S. Røstad simen.rostad@nordicsemi.no

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 14, 2022
@balaji-srin balaji-srin added this to the 2.1.0 milestone Sep 14, 2022
@balaji-srin balaji-srin force-pushed the increase_evt_storage_size branch from 8ec37bb to 1e9bf6e Compare September 14, 2022 13:19
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 14, 2022
Increase the memfault event storage buffer size so that all metrics
generated by the application can be stored and forwarded to memfault
cloud. The default value (1024) results in memfault event storage
becoming full every 15 minutes.

Tested by running the application for over 90 minutes and found that the
error "mflt: Event storage full" is no longer printed.

CIA-769

Signed-off-by: Balaji Srinivasan <balaji.srinivasan@nordicsemi.no>
Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>
@balaji-srin balaji-srin force-pushed the increase_evt_storage_size branch from 1e9bf6e to 13dc32d Compare September 14, 2022 13:20
@jhn-nordic jhn-nordic added the bug Something isn't working label Sep 14, 2022
Copy link
Contributor

@divipillai divipillai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion.

@@ -206,6 +206,7 @@ nRF9160: Asset Tracker v2

* An issue that reports GNSS altitude, accuracy, and speed incorrectly when using LwM2M engine.
* An issue that caused modem FOTA jobs to be reported as not validated to nRF Cloud.
* An issue that caused the memfault event storage buffer getting full which in turn resulted in lost memfault events.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* An issue that caused the memfault event storage buffer getting full which in turn resulted in lost memfault events.
* An issue that caused the memfault event storage buffer to get full, which in turn resulted in lost memfault events.

@greg-fer : FYI. A change log entry for 2.1.0 release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the release notes and added there.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@greg-fer greg-fer mentioned this pull request Sep 14, 2022
14 tasks
@NordicBuilder
Copy link
Contributor

Integration test specification

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-nrf-iot_thingy91 X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@rlubos rlubos merged commit a07224a into nrfconnect:main Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants