mpsl: Use kconfig to determine library path #1302
Conversation
mpsl/Kconfig
Outdated
| help | ||
| Hidden helper option to calculate the library path | ||
|
|
||
| config MPSL_LIB_FLOAT_DIR |
There was a problem hiding this comment.
Maybe ?
| config MPSL_LIB_FLOAT_DIR | |
| config MPSL_LIB_FLOAT_ABI_DIR |
There was a problem hiding this comment.
Yes. I am also not a fan of the naming of MPSL_LIB_DIR, but there is no real connection between the different values. It is a combination of soc, cortex variant, and a bsim hardcoded value that I dont think is used anywhere.
There was a problem hiding this comment.
Another option would be to move more of the logic found in https://github.com/nrfconnect/sdk-nrfxlib/blob/main/common.cmake#L30 to Kconfig and add the possibility to override it somewhere else. I'm not sure if that really solves what we are trying to solve
There was a problem hiding this comment.
The logic there is used by most (all?) of the libraries in nrfxlib. I think the other libraries can do something similar or same as this, but I didnt want to touch the other libraries for now.
There was a problem hiding this comment.
I also dont know if we want to force the same paths to the libraries for everyone. Other libraries may have the same implementation for different hw combinations than sdc/mpsl.
hermabe
force-pushed
the
rfc/library_paths
branch
2 times, most recently
from
579eb64 to
19f5283
Compare
Instead of using SOC and ARCH configs to determine the library paths, use mpsl-specific kconfigs. We will then be able to change the paths independently of which value various upstream configs have. This also makes it simpler to use the same library for different socs, or different libraries for the same cpu core variant. Signed-off-by: Herman Berget <herman.berget@nordicsemi.no>
hermabe
force-pushed
the
rfc/library_paths
branch
from
19f5283 to
89764ea
Compare
Instead of using SOC and ARCH configs to determine the library paths, use mpsl-specific kconfigs. We will then be able to change the paths independently of which value various upstream configs have.
This also makes it simpler to use the same library for different socs, or different libraries for the same cpu core variant.