-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_modem: update library and add nRF9230 binaries #1483
Open
anhmolt
wants to merge
3
commits into
nrfconnect:main
Choose a base branch
from
anhmolt:nrf_modem-add-nrf92-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
PR must not be merged without tech writer approval.
label
Sep 24, 2024
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
from
September 24, 2024 13:06
aa8eda0
to
695dd3e
Compare
/** | ||
* @brief Send a message from the local RPC instance to the remote instance. | ||
* | ||
* @param instance Pointer to RPC instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which RPC instance is this one? The local or the remote one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I see that the word 'instance' have been used with multiple meaning. I have made some improvements.
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
3 times, most recently
from
September 26, 2024 13:22
473c350
to
b31051e
Compare
divipillai
reviewed
Sep 27, 2024
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
2 times, most recently
from
September 27, 2024 15:00
f22c2a2
to
ad00495
Compare
lemrey
approved these changes
Oct 1, 2024
eivindj-nordic
approved these changes
Oct 1, 2024
divipillai
reviewed
Oct 1, 2024
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
2 times, most recently
from
October 1, 2024 14:27
666c707
to
8b98e09
Compare
divipillai
approved these changes
Oct 1, 2024
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
2 times, most recently
from
October 2, 2024 12:43
6d6d675
to
0ad4924
Compare
rlubos
approved these changes
Oct 2, 2024
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
3 times, most recently
from
October 4, 2024 10:26
5a1caa6
to
978709c
Compare
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
4 times, most recently
from
October 7, 2024 13:13
28ede8e
to
60c8d9a
Compare
Increase the width of the first and second column. Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
For a detailed list of changes, see the CHANGELOG file. Co-authored-by: Eivind Jølsgard <eivind.jolsgard@nordicsemi.no> Co-authored-by: Emanuele Di Santo <emdi@nordicsemi.no> Co-authored-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no> Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
Add nrf_modem library binaries for nRF9230 application CPU. These are for internal development. Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
anhmolt
force-pushed
the
nrf_modem-add-nrf92-support
branch
from
October 8, 2024 08:14
60c8d9a
to
2f6884f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a detailed list of changes, see the CHANGELOG file.