nfc: nfc_platform: replace nrfx_err_t with int #1901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magp-nordic
approved these changes
Oct 30, 2025
NRFX drivers now return errno codes. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
mstasiaknordic
force-pushed
the
nrfx_errno_rework
branch
from
a2cb622 to
c7f6f08
Compare
|
grochu
reviewed
Nov 5, 2025
There was a problem hiding this comment.
@mstasiaknordic NRFX error codes are checked directly by the NFC libs: T2T and T4T. They need an update: modify sources, build and deploy, together with the hal_nordic update in sdk-nrf.
| * NRFX_NFCT_NFCID1_DOUBLE_SIZE, or NRFX_NFCT_NFCID1_TRIPLE_SIZE. | ||
| */ | ||
| nrfx_err_t nfc_platform_nfcid1_default_bytes_get(uint8_t * const p_nfcid1_buff, | ||
| int nfc_platform_nfcid1_default_bytes_get(uint8_t * const p_nfcid1_buff, |
There was a problem hiding this comment.
Could you please align indentation in the line below?
grochu
requested changes
Nov 5, 2025
There was a problem hiding this comment.
Additionally https://github.com/nrfconnect/sdk-nrfxlib/blob/main/nfc/src/nfc_nrfx_error_to_nfc.c probably can be removed then.
In the end I think this alignment should be done in the source repo first and come as a single PR to sdk-nrfxlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NRFX drivers now return errno codes.