[nrf fromlist] samples: boards: nordic: coresight_stm: Test STM dicti… #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
from
a4fcb71
to
15293c7
Compare
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
4 times, most recently
from
1f06f96
to
056ee78
Compare
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
2 times, most recently
from
b4076a6
to
74a299a
Compare
|
One of cherry picked commits uses FLPR. |
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
3 times, most recently
from
271756d
to
25115d7
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 7, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
from
25115d7
to
e9c272a
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 7, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 7, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 7, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
Add node with STMESP registers. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no> (cherry picked from commit 8e22222)
…not needed Currently we can assume that flpr and ppr cores are always owned by cpuapp. In that case, cpuapp (which processes ETR buffer content) has access to the memory where logging strings from ppr and flpr are located. Those strings do not need to be appended to the message which is written to the STM (in case of standalone configuration). This approach reduced logging time, e.g. logging a message with one argument takes 1.8us on cpuapp and 6.3us on cpurad. This setting applies only to the case when cpuapp is the owner of those co-oprocessors and shall be updated if that becomes configurable but currently there are no means to detect core owner. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no> (cherry picked from commit c2454f2)
Add interrupt locking during test to ensure that main thread is not interrupts which would impact the test. Add longer sleep time between tests to ensure that all logs are processed on time and not dropped. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit c61e92a)
…pr support Add flpr and ppr core to the sample. Since there are only 2 UARTs available on DK, local UART configuration is using only cpuapp and cpurad. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> (cherry picked from commit d11997d)
Asserts are by default enabled for tests but flpr and ppr are small cores (<64k) and many tests does not fit in memory with asserts enabled. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no> (cherry picked from commit 3786b61)
…ous API UART asynchronous API will ensure highest throughput but it is not necessary as polling API is also supported as a fallback. Do not enforce use of asynchronous API as there might be cases when polling might be used (e.g. to reduce memory footprint). Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no> (cherry picked from commit c6f4e71)
…nous API Asynchronous API is recommended to be used by ETR buffer handler but polling is also supported. Imply UART_ASYNC_API so that it is possible to disable it in project config and fall back to polling if needed. For example to reduce memory footprint. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no> Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no> (cherry picked from commit 2423312)
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
from
e9c272a
to
d65f44a
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 8, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 8, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
from
d65f44a
to
cc5f516
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 8, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
…onary mode Extend STM logger test. Use nrfutil trace to decode STM logs in dictionary mode. Upstream PR: zephyrproject-rtos/zephyr#78947 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
force-pushed
the
NRFX-6024_Extend-STM-dictionary-mode-testing
branch
from
cc5f516
to
f451fa5
Compare
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 8, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 8, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
nordic-segl
added a commit
to nordic-segl/sdk-nrf
that referenced
this pull request
Oct 8, 2024
Include: [nrf fromlist] samples: boards: nordic: coresight_stm: Test STM... dictionary mode nrfconnect/sdk-zephyr#2047 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onary mode
Extend STM logger test.
Use nrfutil trace to decode STM logs in dictionary mode. Add check if timing for a log message is below a threshold. Set thresholds experimentally.
Upstream PR: zephyrproject-rtos/zephyr#78947
manifest-pr-skip