[nrf fromtree] soc: nordic: uicr: Move GEN_UICR options into the main… #3474
+27
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianBoe
force-pushed
the
ncs_gen_uicr_kconfig
branch
from
5095516 to
87797ef
Compare
SebastianBoe
changed the title
SebastianBoe
force-pushed
the
ncs_gen_uicr_kconfig
branch
2 times, most recently
from
e784395 to
ae4cb57
Compare
… Zephyr tree I initially added the GEN_UICR options to the gen_uicr image's Kconfig tree only to not pollute the main tree. But there is a lot of useful help text in the GEN_UICR option's Kconfig file that I would like users to be able to read/reference from the docs. To not increase the complexity of the Kconfig doc generator, we add the GEN_UICR options to the main tree and have them all be disabled for builds other than the gen_uicr image. Being in the main tree has the added benefit of being recognzied by the compliance checker. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no> (cherry picked from commit 70f6cf7ea0c069b9bd5d0246c8883d6349d0a1ad)
SebastianBoe
force-pushed
the
ncs_gen_uicr_kconfig
branch
from
ae4cb57 to
cfafd85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Zephyr tree
I initially added the GEN_UICR options to the gen_uicr image's Kconfig tree only to not pollute the main tree.
But there is a lot of useful help text in the GEN_UICR option's Kconfig file that I would like users to be able to read/reference from the docs.
To not increase the complexity of the Kconfig doc generator, we add the GEN_UICR options to the main tree and have them all be disabled for builds other than the gen_uicr image.
Being in the main tree has the added benefit of being recognzied by the compliance checker.