net: l2: ppp: Allow PPP to transtition ESTABLISH->DEAD #3484
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaylinen
approved these changes
Nov 10, 2025
trantanen
approved these changes
Nov 11, 2025
MarkusLassila
approved these changes
Nov 11, 2025
rlubos
approved these changes
Nov 12, 2025
Contributor
|
@SeppoTakalo I think this needs a rebase to get through the CI, it seems the repos wen't out of sync again and it now fails on some unrelated stuff. |
When remote peer have closed the PPP link normally, the PPP stack on Zephyr side switches back to ESTABLISH phase to be ready for next handshake. When calling net_if_down() on the interface, it should not try to initiate LCP link termination, but instead go directly to DEAD phase. See https://datatracker.ietf.org/doc/html/rfc1661#section-3.2 Upstream PR #: 99078 Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
SeppoTakalo
force-pushed
the
sm_ppp_close
branch
from
82c6ca3 to
1e2467c
Compare
Contributor
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this as fromlist PR as there is a freature-freeze on Zephyr side.
Upstream PR: zephyrproject-rtos/zephyr#99078
When remote peer have closed the PPP link normally, the PPP stack on Zephyr side switches back to ESTABLISH phase to be ready for next handshake.
When calling net_if_down() on the interface, it should not try to initiate LCP link termination, but instead go directly to DEAD phase.
See https://datatracker.ietf.org/doc/html/rfc1661#section-3.2