Skip to content

Commit

Permalink
docs: rewrite implementation notes
Browse files Browse the repository at this point in the history
  • Loading branch information
stigok committed Nov 15, 2022
1 parent 56f90c1 commit 22bd843
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,14 @@ all supported input and secret arguments.

The *build*, *scan* and *push* phases have been merged into one job to
simplify workflow runs. This degrades the visualisation of the pipeline,
but the cost in speed and maintenance is too significant.

The registry URL must be passed as a secret when its sourced from a repository
secret. This seems to be a limitation/security feature of reusable workflows.
This also prevents us from printing the full image refs in the summary output,
but also prevents us from exposing it as workflow outputs. This has been worked
around by outputting tags stripped of their registry URLs.
but the save in speed and maintenance is significant. To separate the steps
it is necessary to cache the built image between jobs, causing a lot of time
spent uploading and downloading artifacts.

The registry URL must be passed as a secret when it's sourced from a repository
secret. This prevents us from printing the full image refs in the workflow
outputs and job summary. This has been worked around by outputting tags stripped
of their registry URLs.

## References

Expand Down

0 comments on commit 22bd843

Please sign in to comment.