refactor(live-status-gw): reassign log levels #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesperstarkar
added
the
Contribution from TV 2 Norge
|
#1131 has been merged. Besides a rebase, is there anything else this is waiting for? We will most likely freeze R51 development soon so it would be nice to get this in before. |
demotes many info messages to debug, some even to silly
ianshade
force-pushed
the
contribute/EAV-158-release51
branch
from
c4bf469
to
0c25dbb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release51 #1140 +/- ##
==============================================
- Coverage 82.87% 57.88% -24.99%
==============================================
Files 169 518 +349
Lines 30001 83616 +53615
Branches 2487 3121 +634
==============================================
+ Hits 24864 48404 +23540
- Misses 5133 35206 +30073
- Partials 4 6 +2 ☔ View full report in Codecov by Sentry. |
|
@mint-dewit, thanks for reminding me about this one. It's was rebased and now is ready for review! |
mint-dewit
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is being opened on behalf of TV 2 Norge.
Type of Contribution
This is a:
Code improvement / Log level improvement
Current Behavior
The Live Status Gateway outputs lots of excessive
infolevel logs. When in use, it can output hundreds of thousands log entries a day. Some of them inform about individual document updates, heartbeat (sent out every 2 seconds), information about collection handlers and topics receiving or sending updates, etc.New Behavior
infolevel is now mostly used for lifecycle events (initialization, connecting/disconnecting, subscribing/unsubscribing). Less relevant messages are demoted todebugor in few cases tosilly.Testing Instructions
Other Information
It's a draft, awaiting merge of #1131 after which I'll rebase this to release51Status