Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clip content statuses regressions SOFIE-2993 #1155

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Feb 23, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Bug fix

Current Behavior

In various scenarios, pieces would be missing correct content statuses.

These issues were introduced by #942

Testing Instructions

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian requested a review from a team February 23, 2024 15:05
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 2.98507% with 195 lines in your changes are missing coverage. Please review.

Project coverage is 58.29%. Comparing base (155397f) to head (391bfc4).
Report is 2 commits behind head on release50.

Files Patch % Lines
...ns/pieceContentStatusUI/checkPieceContentStatus.ts 6.66% 84 Missing ⚠️
...ns/pieceContentStatusUI/rundown/regenerateItems.ts 0.00% 46 Missing ⚠️
...ations/pieceContentStatusUI/rundown/publication.ts 0.00% 31 Missing ⚠️
...eceContentStatusUI/rundown/reactiveContentCache.ts 0.00% 15 Missing ⚠️
...eContentStatusUI/rundown/rundownContentObserver.ts 0.00% 14 Missing ⚠️
...ations/packageManager/expectedPackages/generate.ts 0.00% 3 Missing ⚠️
meteor/lib/api/rundownNotifications.ts 0.00% 1 Missing ⚠️
...cations/pieceContentStatusUI/bucket/publication.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release50    #1155      +/-   ##
=============================================
+ Coverage      58.14%   58.29%   +0.15%     
=============================================
  Files            480      480              
  Lines          78854    79094     +240     
  Branches        3582     4152     +570     
=============================================
+ Hits           45847    46107     +260     
+ Misses         33002    32930      -72     
- Partials           5       57      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian merged commit 17cec2b into release50 Feb 29, 2024
67 of 68 checks passed
@Julusian Julusian deleted the fix/piece-status branch February 29, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants