Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for portions of PlayoutModelImpl SOFIE-2670 #1164

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Mar 6, 2024

About the Contributor

This pull request is posted on behalf of the NRK.

Type of Contribution

This is a: Code improvement

New Behavior

New unit tests

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.00%. Comparing base (748b7a0) to head (d2f12b6).
Report is 28 commits behind head on release51.

Additional details and impacted files
@@              Coverage Diff               @@
##           release51    #1164       +/-   ##
==============================================
- Coverage      82.87%   58.00%   -24.87%     
==============================================
  Files            169      518      +349     
  Lines          30001    83619    +53618     
  Branches        2487     4347     +1860     
==============================================
+ Hits           24864    48507    +23643     
- Misses          5133    35060    +29927     
- Partials           4       52       +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian requested a review from a team March 6, 2024 12:02
@Julusian Julusian changed the title chore: add tests for PlayoutSegmentModelImpl chore: add tests for portions of PlayoutModelImpl SOFIE-2670 Mar 6, 2024
@Julusian Julusian merged commit 5cb987e into release51 Mar 22, 2024
71 of 72 checks passed
@Julusian Julusian deleted the feat/model-unit-tests branch March 22, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants