-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for schema validation of blueprintConfiguration objects #1223
base: release52
Are you sure you want to change the base?
Support for schema validation of blueprintConfiguration objects #1223
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release51 #1223 +/- ##
=============================================
- Coverage 57.95% 57.60% -0.36%
=============================================
Files 485 523 +38
Lines 79860 85257 +5397
Branches 4152 3863 -289
=============================================
+ Hits 46284 49113 +2829
- Misses 33524 36115 +2591
+ Partials 52 29 -23 ☔ View full report in Codecov by Sentry. |
Thank you for this contribution! The NRK team is on vacation at the moment, we'll look at this PR when we're back in August. |
This PR has been opened by SuperFly.tv on behalf of EVS Broadcast Equipment.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behaviour? (You can also link to an open issue here)
When updating blueprintConfiguration objects through the REST API the new configuration is written to the database without any validation that the values conform to any schema.
What is the new behaviour (if this is a feature change)?
This feature supports blueprints that define blueprintConfiguration object JSON schemas and provides methods to support automatic, detailed validation of updated configurations against the published schema before being written to the database. Any invalid properties are reported back to the client.
Included is a small addition to the API that allows the blueprintConfiguration objects to be read and updated without including the rest of the studio or showStyle configuration properties.
Other information:
Status
Affected Areas