fix: resolve an issue with prompter jumping when Parts become PartInstances #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ances and the prompter position is juuuust right
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release50 #1249 +/- ##
=============================================
+ Coverage 57.99% 58.12% +0.13%
=============================================
Files 481 483 +2
Lines 79177 79529 +352
Branches 3479 4035 +556
=============================================
+ Hits 45916 46227 +311
- Misses 33240 33246 +6
- Partials 21 56 +35 ☔ View full report in Codecov by Sentry. |
jstarpl
commented
Aug 26, 2024
Comment on lines
+187
to
+188
| id: partInstance.part._id, | ||
| partInstanceId: partInstance._id, |
There was a problem hiding this comment.
Note to reviewer: this is the important bit.
jstarpl
commented
Aug 26, 2024
| @@ -881,9 +887,10 @@ export const Prompter = translateWithTracker<PropsWithChildren<IPrompterProps>, | |||
| segment.parts.forEach((part) => { | |||
| lines.push( | |||
| <div | |||
| id={`partInstance_${part.id}`} | |||
| id={`part_${part.id}`} | |||
There was a problem hiding this comment.
Note to reviewer: this is the important bit. This will make the prompter treat PartInstances (temporary or not) of the same Part as the same Part, instead of an unrelated third Part.
nytamin
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:
Bug fix
Current Behavior
When the prompter is positioned in a “next-to-be-next” Part, making it become next will make the Prompter jump to the “was-next-just-before/now-is-on-air” Part. The position of the prompter needs to be just right for this to happen, such as when using “go to next/previous part”. Other positions can work too, but the window of tolerance for this is pretty small.
New Behavior
Prompter should maintain its position when the Part in the viewport is repositioned in ENPS, when Parts are repositioned around the Part in the viewport, it should also maintain it’s position when setting the position “just right” (such as explained in Observed behavior section) and doing Takes in Sofie.
Testing
Affected areas
This PR affects the prompter
Time Frame
This Bug Fix is critical for us, please review and merge it as soon as possible.
Other Information
Status