Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mos-connection dependency (SOFIE-3006) #1251

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Aug 29, 2024

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Code improvement

Current Behavior

See nrkno/sofie-mos-connection#103

New Behavior

All incoming MOS data will now be strings, no automatic number conversions

See nrkno/sofie-mos-connection#103

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@nytamin nytamin requested a review from a team as a code owner August 29, 2024 09:27
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.69%. Comparing base (7188a7a) to head (5e2244e).
Report is 63 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/api/ingest/mosDevice/actions.ts 10.00% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1251      +/-   ##
=============================================
- Coverage      58.19%   57.69%   -0.50%     
=============================================
  Files            525      546      +21     
  Lines          84963    86082    +1119     
  Branches        4417     4185     -232     
=============================================
+ Hits           49440    49668     +228     
- Misses         35469    36390     +921     
+ Partials          54       24      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin merged commit d5c2cad into release52 Sep 5, 2024
78 of 80 checks passed
@nytamin nytamin deleted the fix/mos-connection-dep branch September 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants