Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bug "Segment xyz not found" (SOFIE-3544) #1302

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Oct 24, 2024

where the partInstance to be updated where in another rundown than the rundown in the provided context / playoutRundownModel

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Bug fix

Current Behavior

To reproduce the issue:

  • Have a playlist with multiple rundowns in it, from an NRCS
  • Activate and Taks
  • Update the Rundown in the NRCS or trigger "Reload NRCS Data"

There is a "Segment xyz not found" error, that originates from the getPieceInstancesForPart() function.
I figured out that the issue was that getPieceInstancesForPart() was called with a Part from rundown B but the playoutModel was from Rundown A.

New Behavior

I added a special case for when the playoutRundownModel is for another Rundown than the Part, we use the correct one instead from the PlayoutModel.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects ingest operations - syncing changes to Part/PieceInstances.

Time Frame

This Bug Fix is critical for us

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.
    where the partInstance to be updated where in another rundown than the rundown in the provided context / playoutRundownModel

where the partInstance to be updated where in another rundown than the rundown in the provided context / playoutRundownModel
@nytamin nytamin requested a review from a team as a code owner October 24, 2024 10:44
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.92%. Comparing base (913f988) to head (bf311c8).
Report is 44 commits behind head on release51.

Files with missing lines Patch % Lines
...job-worker/src/ingest/syncChangesToPartInstance.ts 7.69% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           release51    #1302    +/-   ##
===========================================
  Coverage      57.91%   57.92%            
===========================================
  Files            526      526            
  Lines          84957    85002    +45     
  Branches        4274     3793   -481     
===========================================
+ Hits           49201    49235    +34     
- Misses         35703    35734    +31     
+ Partials          53       33    -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit eb0416e into release51 Oct 24, 2024
79 of 80 checks passed
@jstarpl jstarpl deleted the fix/ingest-error branch October 24, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants