Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make event types be strongly defined and other changes #25

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

Julusian
Copy link
Contributor

@Julusian Julusian commented Sep 23, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

feature

  • What is the current behavior? (You can also link to an open issue here)

the events emitted by this library are not documented in the typescript typings.

  • What is the new behavior (if this is a feature change)?

This makes them be typed.

There are some other changes here too, which were needed while using the library, maybe they should be submitted separetely;

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (fb7a34b) 52.34% compared to head (07905d7) 51.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   52.34%   51.79%   -0.56%     
==========================================
  Files          37       37              
  Lines         852      863      +11     
  Branches      140      146       +6     
==========================================
+ Hits          446      447       +1     
- Misses        355      363       +8     
- Partials       51       53       +2     
Files Coverage Δ
src/asyncHandlers/configuration.ts 36.36% <100.00%> (ø)
src/asyncHandlers/displayTimecode.ts 57.14% <100.00%> (ø)
src/asyncHandlers/remoteInfo.ts 62.50% <100.00%> (ø)
src/asyncHandlers/slotInfo.ts 100.00% <100.00%> (ø)
src/asyncHandlers/timelinePosition.ts 57.14% <100.00%> (ø)
src/commands/clips.ts 13.63% <ø> (ø)
src/commands/deviceInfo.ts 30.00% <ø> (ø)
src/commands/diskList.ts 13.33% <ø> (ø)
src/commands/slotInfo.ts 21.42% <ø> (ø)
src/commands/slotSelect.ts 17.64% <0.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian marked this pull request as ready for review September 29, 2023 21:05
@Julusian Julusian changed the title feat: make event types be strongly defined feat: make event types be strongly defined and other changes Oct 6, 2023
@Julusian Julusian requested a review from mint-dewit October 6, 2023 08:33
@Julusian Julusian merged commit 3958bdf into master Oct 18, 2023
@Julusian Julusian deleted the feat/strong-event-types branch October 18, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

508 response codes use 'active slot' instead of 'slotId'
3 participants