Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sisyfos): Send fadeTime with faderLevel if specified #275

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

PeterC89
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature (sisyfos)

  • What is the current behavior? (You can also link to an open issue here)
    Sisyfos cannot change fade time if the fader isPgm value isn't changed, so level changes cannot have adjustable fade time.

  • What is the new behavior (if this is a feature change)?
    In conjunction with Allow fade times to be set with each level change tv2/sisyfos-audio-controller#271 the fadeTime property is sent with level changes.

  • Other information:
    Tested against an unmodified version of Sisyfos (4.18.0) and appears to have no ill effects so should be fine to be in TSR until the Sisyfos PR is merged.

@Julusian Julusian requested a review from a team August 15, 2023 08:51
@jstarpl
Copy link
Member

jstarpl commented Aug 16, 2023

@PeterC89 Technically, the release50 is feature-frozen. How big of a problem would it be for you if we pushed this into release51 instead?

@PeterC89
Copy link
Contributor Author

@jstarpl Not a problem at all, I can always build playout gateway manually if I need it urgently

@mint-dewit mint-dewit changed the base branch from release50 to release51 August 16, 2023 10:07
@mint-dewit mint-dewit merged commit 7bd735e into nrkno:release51 Aug 16, 2023
17 of 18 checks passed
@PeterC89 PeterC89 deleted the feat/sisyfosFadeTimeWithLevel branch August 22, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants