feat(sisyfos): Send fadeTime with faderLevel if specified #275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature (sisyfos)
What is the current behavior? (You can also link to an open issue here)
Sisyfos cannot change fade time if the fader
isPgm
value isn't changed, so level changes cannot have adjustable fade time.What is the new behavior (if this is a feature change)?
In conjunction with Allow fade times to be set with each level change tv2/sisyfos-audio-controller#271 the
fadeTime
property is sent with level changes.Other information:
Tested against an unmodified version of Sisyfos (4.18.0) and appears to have no ill effects so should be fine to be in TSR until the Sisyfos PR is merged.