Feat/vmix media reload retrying #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clips into playlists twice
…date things in one place but not the other
fix(vmix): fix scenario where the media load retry system would load clips into playlists twice
|
Pending testing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release50 #277 +/- ##
=============================================
- Coverage 34.86% 34.62% -0.24%
=============================================
Files 99 99
Lines 10109 11144 +1035
Branches 2483 2979 +496
=============================================
+ Hits 3524 3859 +335
- Misses 5997 6594 +597
- Partials 588 691 +103 ☔ View full report in Codecov by Sentry. |
…trying * fix/media-load-retrying: chore: rename variable chore: refactor for simplicity and clarity fix: prevent conflicts with sisyfos fix: media re-playing shortly after completing
…x-media-reload-retrying * commit 'c75d4d8ee6271be95d1fcd60f8741c3281db0521': fix: another potential fix for this system not working as intended
* release50: 9.0.0-release50.6 chore: update sofie-chef types, stricter types fix: promisify cb from threadedclass chore: revert: only stop windows that we know of in the Mappings chore: lint fix(chef): only stop windows that we know of in the Mappings fix(sofie-chef): resync state upon reconnect chore(sofie-chef): refactor & rename chore: update Chef API feat: atem audio routing control SOFIE-2512 (#274) chore(vmix): add state debugging
…x-media-reload-retrying * commit 'feb709b5f4a80ce0ebcbe13329c86cec9904fbec': fix: add a future-proof "resetResolver" event
…x-media-reload-retrying * commit '14c73faa69f1a4cbdc007fcf4fe301bef3999519': chore: fix tests
|
I've done a round of testing, and this seems to work as expected. The bugs are gone and I don't see any other problems. No structured testing, just general usage to see if vmix behaves in general. |
nytamin
added
the
contribution from TV 2 Norge
nytamin
approved these changes
Oct 18, 2023
packages/timeline-state-resolver/src/integrations/vmix/$schemas/options.json
Show resolved
Hide resolved
packages/timeline-state-resolver/src/integrations/vmix/__tests__/vmix.spec.ts
Outdated
Show resolved
Hide resolved
packages/timeline-state-resolver/src/integrations/vmix/index.ts
Outdated
Show resolved
Hide resolved
packages/timeline-state-resolver/src/integrations/vmix/$schemas/options.json
Outdated
Show resolved
Hide resolved
Addresses comments in PR #277 review.
This implementation aligns with the CasparCG-integration logic of falling back to the default also in case of non-numeric numbers.
nytamin
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending #272
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: