Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider ModuleStore health in /health endpoint #4

Open
stigok opened this issue May 3, 2022 · 2 comments
Open

Consider ModuleStore health in /health endpoint #4

stigok opened this issue May 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@stigok
Copy link
Contributor

stigok commented May 3, 2022

The /health endpoint is currently a dummy implementation that always reports 200 OK.
Proposing extending the ModuleStore interface to implement Health(ctx context.Context) to improve the health status report of the app.
@stigok stigok added the enhancement New feature or request label May 3, 2022
@stigok stigok mentioned this issue May 3, 2022
Merged
@stigok
Copy link
Contributor Author

stigok commented Jun 14, 2022

Preqreq #36

@umglurf
Copy link
Contributor

umglurf commented Jul 1, 2022

It would also be nice if it could check that the cache is ready, so that new instances are not added to the kubernetes load balancer until they return valid data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stigok @umglurf