Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umglurf
requested changes
Apr 27, 2022
umglurf
requested changes
Apr 27, 2022
BREAKING CHANGE
Should ease development workflow, especially when `make reuse` is run as a pre-commit hook.
umglurf
approved these changes
Apr 28, 2022
martensson
approved these changes
May 3, 2022
| - `MemoryStore`: in-memory store that can be populated manually | ||
| - Must be populated manually | ||
| - `GitHubStore`: queries the GitHub API for modules, version tags and SSH download URLs | ||
| - A query for module `namespace/name/provider` will return repository `namespace/name` |
There was a problem hiding this comment.
Om jeg ikke husker feil så snakket vi om å implementere en "generic" path som default?
| - `provider` part of module URLs is not implemented. Can be set to anything at all. | ||
| - Works for a single specified org/user | ||
| - No verification for the repo actually being a Terraform repo | ||
|
|
There was a problem hiding this comment.
Hvilke typ av repos vil GithubStore regne som TF moduler? (topicFilter)
|
|
||
| router *chi.Mux | ||
| authTokens []string | ||
| moduleStore core.ModuleStore |
There was a problem hiding this comment.
Ikke viktig akkurat nå, men en framtide feature kan være å støtte flere ModuleStores samtidig. 😇
| } | ||
| } | ||
|
|
||
| func (app *App) Health() http.HandlerFunc { |
There was a problem hiding this comment.
Framtide feature er å sjekke status på backends også (tilgang mot Github for eksempel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.