fix: add windowsHide: true in more places

nrwl · Sep 20, 2024 · 8f3a719 · 8f3a719
1 parent df7922e
commit 8f3a719
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/libs/language-server/workspace/src/lib/nx-stop-daemon.ts b/libs/language-server/workspace/src/lib/nx-stop-daemon.ts
@@ -16,5 +16,6 @@ export async function nxStopDaemon(workspacePath: string, logger: Logger) {
   );
   execSync(`${packageManagerCommands.exec} nx daemon --stop`, {
     cwd: workspacePath,
+    windowsHide: true,
   });
 }
diff --git a/libs/vscode/add-dependency/src/lib/vscode-add-dependency.ts b/libs/vscode/add-dependency/src/lib/vscode-add-dependency.ts
@@ -277,7 +277,14 @@ async function getWorkspaceAddFlag(
     private?: boolean;
   }>(join(workspacePath, 'package.json'));
   if (pkgManager === 'yarn') {
-    const isYarnV1 = major(execSync('yarn --version').toString().trim()) === 1;
+    const isYarnV1 =
+      major(
+        execSync('yarn --version', {
+          windowsHide: true,
+        })
+          .toString()
+          .trim()
+      ) === 1;
     const isWorkspace =
       !!pkgJson.private &&
       !!pkgJson.workspaces &&

diff --git a/libs/vscode/nx-cloud-view/src/lib/get-cloud-onboarding-url.ts b/libs/vscode/nx-cloud-view/src/lib/get-cloud-onboarding-url.ts
@@ -110,6 +110,7 @@ export function getGithubSlugOrNull(): string | null {
   try {
     const gitRemote = execSync('git remote -v', {
       stdio: 'pipe',
+      windowsHide: true,
     }).toString();
     // If there are no remotes, we default to github
     if (!gitRemote || gitRemote.length === 0) {