handle uncaught errors in vscode

nrwl · Aug 21, 2024 · d134c5d · d134c5d
1 parent 7030f0f
commit d134c5d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/libs/vscode/telemetry/src/lib/google-analytics-sender.ts b/libs/vscode/telemetry/src/lib/google-analytics-sender.ts
@@ -28,7 +28,10 @@ export class GoogleAnalyticsSender implements TelemetrySender {
     );
   }
   sendErrorData(error: Error, data?: Record<string, any>): void {
-    throw new Error('Method not implemented.');
+    this.sendEventData('misc.exception', {
+      ...data,
+      name: error.name,
+    });
   }
 
   private _eventParams() {

diff --git a/libs/vscode/telemetry/src/lib/init.ts b/libs/vscode/telemetry/src/lib/init.ts
@@ -10,14 +10,12 @@ export function getTelemetry() {
   return telemetry;
 }
 
-// using shared memory here is a shortcut, this should be an api call
 export function initTelemetry(production: boolean) {
   const telemetrySender: TelemetrySender = production
     ? new GoogleAnalyticsSender(production)
     : new LoggerSender();
 
   telemetry = env.createTelemetryLogger(telemetrySender, {
-    ignoreUnhandledErrors: true,
     ignoreBuiltInCommonProperties: true,
   });
 

diff --git a/libs/vscode/telemetry/src/lib/logger-sender.ts b/libs/vscode/telemetry/src/lib/logger-sender.ts
@@ -13,6 +13,6 @@ export class LoggerSender implements TelemetrySender {
     console.log(header(eventName), data);
   }
   sendErrorData(error: Error, data?: Record<string, any>): void {
-    console.log(errorHeader(error.message), data);
+    console.log(errorHeader(error.name), data);
   }
 }