feat: allow filtering in the nx project tree view

nrwl · Mar 26, 2021 · eab4d76 · eab4d76
1 parent abdddbd
commit eab4d76
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 20 deletions.
diff --git a/apps/vscode/src/package.json b/apps/vscode/src/package.json
@@ -66,13 +66,8 @@
       ],
       "view/item/context": [
         {
-          "command": "nxConsole.revealInExplorer",
-          "when": "view == nxConsoleJson && viewItem == project",
-          "group": "inline"
-        },
-        {
-          "command": "nxConsole.runTask",
-          "when": "view == nxConsoleJson && viewItem == task",
+          "command": "nxConsole.editWorkspaceJson",
+          "when": "view == nxProjects",
           "group": "inline"
         },
         {
@@ -250,21 +245,20 @@
           "dark": "assets/refresh-dark.svg"
         }
       },
+      {
+        "command": "nxConsole.editWorkspaceJson",
+        "title": "Edit workspace definition",
+        "icon": "$(go-to-file)"
+      },
       {
         "command": "nxConsole.revealInExplorer",
         "title": "Reveal in Explorer",
-        "icon": {
-          "light": "assets/folder-light.svg",
-          "dark": "assets/folder-dark.svg"
-        }
+        "icon": "$(folder)"
       },
       {
         "command": "nxConsole.runTask",
         "title": "Execute task",
-        "icon": {
-          "light": "assets/continue-light.svg",
-          "dark": "assets/continue-dark.svg"
-        }
+        "icon": "$(play)"
       },
       {
         "category": "ng",

diff --git a/libs/vscode/nx-project-view/src/lib/nx-project-tree-provider.ts b/libs/vscode/nx-project-view/src/lib/nx-project-tree-provider.ts
@@ -75,11 +75,6 @@ export class NxProjectTreeProvider extends AbstractTreeProvider<NxProjectTreeIte
         ? TreeItemCollapsibleState.Collapsed
         : TreeItemCollapsibleState.None
     );
-    item.command = {
-      title: 'Edit workspace definition',
-      command: 'nxConsole.editWorkspaceJson',
-      arguments: [item],
-    };
     if (!workspaceJsonLabel.target) {
       const projectDef = this.cliTaskProvider.getProjects()[
         workspaceJsonLabel.project