chore: remove deps from angularcli to fully get rid of tslint #1057
Conversation
Nx Cloud ReportCI ran the following commands for commit f51584a. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
- I think that option filtering on Arrays without items should be in the
normalizeSchema/schemaToOptionsinstead of the UI form - I don't quite get the OptionPropertyDescription. Can you explain that to me a bit?
- And just some other comments I had out loud while thinking this thru
| @@ -1,9 +1,29 @@ | |||
| import { Option as CliOption, OptionType } from '@angular/cli/models/interface'; | |||
| import { Schema } from '@nrwl/tao/src/shared/params'; | |||
|
|
|||
There was a problem hiding this comment.
wonders if Nx should actually define an OptionType enum in the PropertyDescription type
...but it doesn't right now, so oh well.
There was a problem hiding this comment.
You're right, it doesn't. But that doesn't stop us from getting this type from the schema 😉
| alias?: string; | ||
| hidden?: boolean; | ||
| deprecated?: boolean | string; | ||
| } & OptionPropertyDescription; | ||
|
|
||
| export interface Option extends Omit<CliOption, 'default'> { | ||
| tooltip?: string; | ||
| itemTooltips?: ItemTooltips; | ||
| items?: string[] | ItemsWithEnum; |
There was a problem hiding this comment.
noting that Angular's Option had aliases, but Nx/tao PropertyDescription has alias. Angular's Option also has the positional property.
Bah, this Schema stuff is already complex.
| }; | ||
| const getSchema = async ( | ||
| options: any[], |
There was a problem hiding this comment.
It does maybe feel like maybe Nx/tao should be exporting more than just the Schema type so we could use Properties. I can live with this, just commenting.
| @@ -321,3 +320,26 @@ export function toLegacyWorkspaceFormat(w: any) { | |||
| } | |||
| return w; | |||
| } | |||
|
|
|||
| function schemaToOptions(schema: Schema): CliOption[] { | |||
There was a problem hiding this comment.
suggestion to rename (acc, curr) to (cliOptions, optionName) to make this slightly more readable
| option.items && | ||
| (option.items as string[]).length === 0 | ||
| ); | ||
|
|
There was a problem hiding this comment.
I would say this filtering more likely belongs in normalizeSchema/schemaToOptions
There was a problem hiding this comment.
I was thinking that too, but I moved it here because I feel like this is a UI issue because we don't support those advanced array types.
I can move it 😄
There was a problem hiding this comment.
yeah.. I guess it seems like a schema responsibility to me, and we'll have to figure out how to get the Schema to support that, which might be even harder now that we don't have it typed upstream.
Cammisuli
force-pushed
the
remove-deps-from-angularcli
branch
from
b33df34 to
6b77797
Compare
Cammisuli
force-pushed
the
remove-deps-from-angularcli
branch
from
0f46f3b to
8c94b0f
Compare
What it does
Removes imports to
@angular/clifrom the code base so that we can fully get rid of tslint.This requires using
@nrwl/taoinstead to get information from generators and executors.