Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: welcome view and getting started walkthrough #1069

Merged
merged 11 commits into from
Aug 6, 2021

Conversation

sandikbarr
Copy link
Contributor

@sandikbarr sandikbarr commented May 11, 2021

A recent VS Code update added experimental support for Welcome Page walkthroughs.

I am only able to get the walkthrough to launch on installation in Insiders with the setting "workbench.welcomePage.experimental.extensionContributions": true.

But without Insiders, we still get this new button on the Welcome View to launch our walkthough:
Screen Shot 2021-07-30 at 3 50 01 PM

The walkthrough docs were copied from nx.dev, minus the videos. I could not get external links to work from within the walkthrough so wasn't able to include those.
Screen Shot 2021-07-30 at 3 50 33 PM

(just some previous research notes:)

I also checked out what GitLens is doing with their welcome and latest updates content, which is a different direction we may want to explore for a more robust solution. They store the latest installed version, and when someone has installed it for the first time they show a Welcome Page custom webview, and when someone has just updated to a new version, they show a Latest Updates custom webview.

@nx-cloud
Copy link

nx-cloud bot commented May 11, 2021

Nx Cloud Report

CI ran the following commands for commit 20ab5f2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --all --parallel --target=build
#000000 nx run-many --all --parallel --target=test
#000000 nx run-many --all --parallel --target=lint

Sent with 💌 from NxCloud.

@@ -16,7 +16,7 @@ Nx transformed the Angular ecosystem. With it, you can get a full-stack applicat

## Why Nx Console?

Professional developers use both command-line tools and user interfaces. They commit in the terminal, but resolve conflicts in VSCode or WebStorm. They use the right tool for the job.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

synced this up with the nx.dev content

@@ -587,7 +647,15 @@
"id": "nxProjects",
"name": "Projects",
"when": "isNxWorkspace || isAngularWorkspace"
}
Copy link
Contributor Author

@sandikbarr sandikbarr May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a "welcome view" shows up along with the empty 'Select workspace' treeview when an angular or Nx project isn't open.
Screen Shot 2021-05-11 at 2 49 06 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this up above the generate and run target view?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks like we can! Great idea

@sandikbarr sandikbarr changed the title Feat: welcome view and getting started walkthrough feat: welcome view and getting started walkthrough May 11, 2021
@sandikbarr sandikbarr force-pushed the feat/getting-started branch from beb0058 to a9f7077 Compare July 30, 2021 20:59
@sandikbarr sandikbarr marked this pull request as ready for review July 30, 2021 21:07
@sandikbarr sandikbarr requested a review from Cammisuli July 30, 2021 21:07
@@ -587,7 +647,15 @@
"id": "nxProjects",
"name": "Projects",
"when": "isNxWorkspace || isAngularWorkspace"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this up above the generate and run target view?

@Cammisuli Cammisuli merged commit 7281905 into nrwl:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants