chore: update nx to 18

apps/generate-ui-v2-e2e/project.json

@@ -20,13 +20,6 @@
         }
       }
     },
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["apps/generate-ui-v2-e2e/**/*.{js,ts}"]
-      }
-    },
     "serve": {
       "executor": "@nx/web:file-server",
       "options": {

apps/generate-ui-v2/jest.config.ts

@@ -8,4 +8,5 @@ export default {
   },
   moduleFileExtensions: ['ts', 'js', 'html'],
   coverageDirectory: '../../coverage/apps/generate-ui-v2',
+  passWithNoTests: true,
 };

apps/generate-ui-v2/project.json

@@ -38,20 +38,6 @@
           }
         }
       }
-    },
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["apps/generate-ui-v2/**/*.ts"]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
-      "options": {
-        "jestConfig": "apps/generate-ui-v2/jest.config.ts"
-      }
     }
   },
   "tags": ["type:generate-ui"]

apps/generate-ui-v2/src/components/button.ts

@@ -15,7 +15,7 @@ export class Button extends EditorContext(LitElement) {
   @property()
   color: string;
   @property({ type: Boolean })
-  applyFillColor: boolean = false;
+  applyFillColor = false;
 
   render() {
     return this.editor === 'vscode'

apps/generate-ui-v2/src/components/cwd-breadcrumb.ts

@@ -12,7 +12,7 @@ import {
 export class CwdBreadcrumb extends GeneratorContextContext(
   EditorContext(LitElement)
 ) {
-  @state() _path: string = '';
+  @state() _path = '';
   @state() isEditable = false;
 
   set path(value: string) {
@@ -67,7 +67,11 @@ export class CwdBreadcrumb extends GeneratorContextContext(
       >
         <span class="pr-2"> Working Directory: </span>
         <span
-          @click="${hasPathSegments ? this.resetPath : () => {}}"
+          @click="${hasPathSegments
+            ? this.resetPath
+            : () => {
+                return;
+              }}"
           class="${hasPathSegments
             ? 'hover:text-primary cursor-pointer underline'
             : ''}"

apps/generate-ui-v2/src/components/icon.ts

@@ -11,7 +11,7 @@ export class Icon extends EditorContext(LitElement) {
   color = '';
 
   @property({ type: Boolean })
-  applyFillColor: boolean = false;
+  applyFillColor = false;
 
   render() {
     if (this.editor === 'intellij') {

apps/generate-ui/project.json

@@ -87,22 +87,6 @@
         }
       },
       "outputs": ["{options.outputPath}"]
-    },
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": [
-          "apps/generate-ui/src/**/*.ts",
-          "apps/generate-ui/src/**/*.html"
-        ]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "options": {
-        "jestConfig": "apps/generate-ui/jest.config.ts"
-      },
-      "outputs": ["{workspaceRoot}/coverage/apps/generate-ui"]
     }
   },
   "implicitDependencies": ["generate-ui-styles"],

apps/intellij/project.json

@@ -29,6 +29,9 @@
         "command": "./gradlew :apps:intellij:check"
       }
     },
+    "lint": {
+      "executor": "nx:noop"
+    },
     "x-lint": {
       "//": "Run inspections take a long time on the CI. Disable for now",
       "executor": "nx:run-commands",

apps/nxls/jest.config.ts

@@ -14,4 +14,5 @@ export default {
   },
   moduleFileExtensions: ['ts', 'js', 'html'],
   coverageDirectory: '../../coverage/apps/nxls',
+  passWithNoTests: true,
 };

apps/nxls/project.json

@@ -47,7 +47,8 @@
         "externalDependencies": "all",
         "target": "node",
         "optimization": true,
-        "extractLicenses": true
+        "extractLicenses": true,
+        "webpackConfig": "apps/nxls/webpack.config.js"
       }
     },
     "build": {
@@ -97,20 +98,6 @@
         }
       }
     },
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["apps/nxls/**/*.ts"]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/apps/nxls"],
-      "options": {
-        "jestConfig": "apps/nxls/jest.config.ts"
-      }
-    },
     "semantic-release": {
       "executor": "@theunderscorer/nx-semantic-release:semantic-release",
       "options": {

apps/nxls/webpack.config.js

@@ -0,0 +1,8 @@
+const { composePlugins, withNx } = require('@nx/webpack');
+
+// Nx plugins for webpack.
+module.exports = composePlugins(withNx(), (config) => {
+  // Note: This was added by an Nx migration. Webpack builds are required to have a corresponding Webpack config file.
+  // See: https://nx.dev/recipes/webpack/webpack-config-setup
+  return config;
+});

apps/vscode-e2e/project.json

@@ -4,13 +4,6 @@
   "sourceRoot": "apps/vscode-e2e/src",
   "projectType": "application",
   "targets": {
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": ["apps/vscode-e2e/**/*.ts"]
-      }
-    },
     "_e2e": {
       "executor": "nx:run-commands",
       "options": {

apps/vscode/project.json

@@ -192,12 +192,6 @@
       },
       "dependsOn": ["^build"]
     },
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": ["apps/vscode/**/*.ts"]
-      }
-    },
     "package": {
       "executor": "nx:run-commands",
       "dependsOn": ["build", "^build"],

libs/generate-ui/components/project.json

@@ -3,23 +3,6 @@
   "$schema": "../../../node_modules/nx/schemas/project-schema.json",
   "projectType": "library",
   "sourceRoot": "libs/generate-ui/components/src",
-  "targets": {
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": [
-          "libs/generate-ui/components/src/**/*.ts",
-          "libs/generate-ui/components/src/**/*.html"
-        ]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "options": {
-        "jestConfig": "libs/generate-ui/components/jest.config.ts"
-      },
-      "outputs": ["{workspaceRoot}/coverage/libs/generate-ui/components"]
-    }
-  },
+  "targets": {},
   "tags": ["type:generate-ui"]
 }

libs/generate-ui/feature-task-execution-form/project.json

@@ -4,24 +4,6 @@
   "projectType": "library",
   "sourceRoot": "libs/generate-ui/feature-task-execution-form/src",
   "targets": {
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "options": {
-        "lintFilePatterns": [
-          "libs/generate-ui/feature-task-execution-form/src/**/*.ts",
-          "libs/generate-ui/feature-task-execution-form/src/**/*.html"
-        ]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "options": {
-        "jestConfig": "libs/generate-ui/feature-task-execution-form/jest.config.ts"
-      },
-      "outputs": [
-        "{workspaceRoot}/coverage/libs/generate-ui/feature-task-execution-form"
-      ]
-    },
     "storybook": {
       "executor": "@storybook/angular:start-storybook",
       "options": {

libs/generate-ui/styles/project.json

@@ -3,7 +3,11 @@
   "$schema": "../../../node_modules/nx/schemas/project-schema.json",
   "projectType": "library",
   "sourceRoot": "libs/generate-ui/styles/src",
-  "targets": {},
+  "targets": {
+    "lint": {
+      "executor": "nx:noop"
+    }
+  },
   "generators": {},
   "tags": ["type:generate-ui"]
 }

libs/language-server/capabilities/code-completion/project.json

@@ -3,25 +3,6 @@
   "$schema": "../../../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "libs/language-server/capabilities/code-completion/src",
   "projectType": "library",
-  "targets": {
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": [
-          "libs/language-server/capabilities/code-completion/**/*.ts"
-        ]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": [
-        "{workspaceRoot}/coverage/libs/language-server/capabilities/code-completion"
-      ],
-      "options": {
-        "jestConfig": "libs/language-server/capabilities/code-completion/jest.config.ts"
-      }
-    }
-  },
+  "targets": {},
   "tags": ["type:lsp"]
 }

libs/language-server/capabilities/code-completion/src/lib/get-completion-items.spec.ts

@@ -1,9 +1,12 @@
-import { configureJsonLanguageService } from '@nx-console/language-server/utils';
+import {
+  configureJsonLanguageService,
+  getLanguageModelCache,
+} from '@nx-console/language-server/utils';
 import {
   CompletionType,
   EnhancedJsonSchema,
 } from '@nx-console/shared/json-schema';
-import * as workspace from '@nx-console/language-server/workspace';
+import type * as workspace from '@nx-console/language-server/workspace';
 import { vol } from 'memfs';
 import {
   ClientCapabilities,
@@ -135,6 +138,7 @@ describe('getCompletionItems', () => {
 
   afterAll(() => {
     vol.reset();
+    getLanguageModelCache().dispose();
   });
 
   it('should return all completion items without a glob', async () => {

libs/language-server/capabilities/definition/jest.config.ts

@@ -8,4 +8,5 @@ export default {
   moduleFileExtensions: ['ts', 'js', 'html'],
   coverageDirectory:
     '../../../../coverage/libs/language-server/capabilities/definition',
+  passWithNoTests: true,
 };

libs/language-server/capabilities/definition/project.json

@@ -3,23 +3,6 @@
   "$schema": "../../../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "libs/language-server/capabilities/definition/src",
   "projectType": "library",
-  "targets": {
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": [
-          "libs/language-server/capabilities/definition/**/*.ts"
-        ]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
-      "options": {
-        "jestConfig": "libs/language-server/capabilities/definition/jest.config.ts"
-      }
-    }
-  },
+  "targets": {},
   "tags": ["type:lsp"]
 }

libs/language-server/capabilities/document-links/project.json

@@ -3,25 +3,6 @@
   "$schema": "../../../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "libs/language-server/capabilities/document-links/src",
   "projectType": "library",
-  "targets": {
-    "lint": {
-      "executor": "@nx/eslint:lint",
-      "outputs": ["{options.outputFile}"],
-      "options": {
-        "lintFilePatterns": [
-          "libs/language-server/capabilities/document-links/**/*.ts"
-        ]
-      }
-    },
-    "test": {
-      "executor": "@nx/jest:jest",
-      "outputs": [
-        "{workspaceRoot}/coverage/libs/language-server/capabilities/document-links"
-      ],
-      "options": {
-        "jestConfig": "libs/language-server/capabilities/document-links/jest.config.ts"
-      }
-    }
-  },
+  "targets": {},
   "tags": ["type:lsp"]
 }